core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0289-Avoid-Chunk-Lookups-fo...

90 lines
4.1 KiB
Diff
Raw Normal View History

update upstream
2018-07-29 16:42:07 +00:00
From 13a7093e1a97f051dff1b9f20e415d15a18f0fcf Mon Sep 17 00:00:00 2001
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
From: Aikar <aikar@aikar.co>
Date: Wed, 4 Jul 2018 03:39:51 -0400
Subject: [PATCH] Avoid Chunk Lookups for Entity/TileEntity Current Chunk
In many places where we simply want the current chunk the entity
is in, instead of doing a hashmap lookup for it, we now have access
to the object directly on the Entity/TileEntity object we can directly grab.
Use that local value instead to reduce lookups in many hot places.
diff --git a/src/main/java/net/minecraft/server/Chunk.java b/src/main/java/net/minecraft/server/Chunk.java
update upstream
2018-07-29 16:42:07 +00:00
index 8e6d32bd8..3ac115ff6 100644
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
--- a/src/main/java/net/minecraft/server/Chunk.java
+++ b/src/main/java/net/minecraft/server/Chunk.java
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
@@ -721,6 +721,7 @@ public class Chunk implements IChunkAccess {
((HeightMap) this.heightMap.get(heightmap_type)).a(along);
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
}
+ public void removeEntity(Entity entity) { b(entity); } // Paper - OBFHELPER
public void b(Entity entity) {
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
this.a(entity, entity.af);
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
}
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
update upstream
2018-07-29 16:42:07 +00:00
index a961705fb..8dc6ca207 100644
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
update upstream
2018-07-29 16:42:07 +00:00
@@ -1219,12 +1219,15 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
int j;
// Paper start - Set based removal lists
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
for (Entity e : this.g) {
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
+ /*
j = e.getChunkZ();
int k = e.getChunkX();
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
if (e.inChunk && this.isChunkLoaded(k, j, true)) {
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
this.getChunkAt(k, j).b(e);
- }
+ }*/
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
+ Chunk chunk = e.inChunk ? e.getCurrentChunk() : null;
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
+ if (chunk != null) chunk.removeEntity(e);
}
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
for (Entity e : this.g) {
update upstream
2018-07-29 16:42:07 +00:00
@@ -1285,12 +1288,17 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
this.methodProfiler.e();
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
this.methodProfiler.a("remove");
if (entity.dead) {
+ // Paper start
+ /*
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
j = entity.ae;
int l = entity.ag;
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
if (entity.inChunk && this.isChunkLoaded(j, l, true)) {
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
this.getChunkAt(j, l).b(entity);
- }
+ }*/
NOT FINISHED! 1.13 pre-7 I need more creative commit messages.
2018-07-18 23:16:19 +00:00
+ Chunk chunk = entity.inChunk ? entity.getCurrentChunk() : null;
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
+ if (chunk != null) chunk.removeEntity(entity);
+ // Paper end
guardEntityList = false; // Spigot
this.entityList.remove(this.tickPosition--); // CraftBukkit - Use field for loop variable
update upstream
2018-07-29 16:42:07 +00:00
@@ -1335,7 +1343,7 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
BlockPosition blockposition = tileentity.getPosition();
// Paper start - Skip ticking in chunks scheduled for unload
- net.minecraft.server.Chunk chunk = this.getChunkIfLoaded(blockposition);
+ net.minecraft.server.Chunk chunk = tileentity.getCurrentChunk();
boolean shouldTick = chunk != null;
if(this.paperConfig.skipEntityTickingInChunksScheduledForUnload)
shouldTick = shouldTick && !chunk.isUnloading() && chunk.scheduledForUnload == null;
update upstream
2018-07-29 16:42:07 +00:00
@@ -1371,8 +1379,11 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
tilesThisCycle--;
this.tileEntityListTick.remove(tileTickPosition--);
//this.tileEntityList.remove(tileentity); // Paper - remove unused list
- if (this.isLoaded(tileentity.getPosition())) {
Missed a case where to remove a chunk lookup on TE removal (performance, not bug fix)
2018-07-04 21:29:10 +00:00
- this.getChunkAtWorldCoords(tileentity.getPosition()).d(tileentity.getPosition());
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
+ // Paper start
+ net.minecraft.server.Chunk chunk = tileentity.getCurrentChunk();
+ if (chunk != null) {
Missed a case where to remove a chunk lookup on TE removal (performance, not bug fix)
2018-07-04 21:29:10 +00:00
+ chunk.removeTileEntity(tileentity.getPosition());
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
+ // Paper end
}
}
Missed a case where to remove a chunk lookup on TE removal (performance, not bug fix)
2018-07-04 21:29:10 +00:00
}
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00
--
Multitude of changes to attempt to fix #1199
2018-07-12 20:42:56 +00:00
2.18.0
Avoid Chunk Lookups for Entity/TileEntity Current Chunk In many places where we simply want the current chunk the entity is in, instead of doing a hashmap lookup for it, we now have access to the object directly on the Entity/TileEntity object we can directly grab. Use that local value instead to reduce lookups in many hot places.
2018-07-04 07:56:57 +00:00