.github/workflows/smoke.yml

@@ -1,74 +0,0 @@
-# This workflow builds the iOS and Android apps, just to check they build without error
-
-name: Smoke build
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-
-jobs:
-  build-android:
-    name: Android
-    runs-on: macos-latest
-    steps:
-      - name: Set up Go 1.22
-        uses: actions/setup-go@v4
-        with:
-          go-version: "1.22"
-
-      - uses: actions/setup-java@v2
-        with:
-          distribution: 'zulu'
-          java-version: '17'
-
-      - name: Install flutter
-        uses: subosito/flutter-action@v2
-        with:
-          flutter-version: '3.24.1'
-
-      - name: Check out code
-        uses: actions/checkout@v3
-
-      - name: install dependencies
-        env:
-          TOKEN: ${{ secrets.MACHINE_USER_PAT }}
-        run: |
-          go install golang.org/x/mobile/cmd/gomobile@latest
-          gomobile init
-          flutter pub get
-          touch env.sh
-
-      - name: Build Android debug
-        run: flutter build appbundle --debug
-
-  build-ios:
-    name: iOS
-    runs-on: macos-latest
-
-    steps:
-      - name: Set up Go 1.22
-        uses: actions/setup-go@v4
-        with:
-          go-version: "1.22"
-
-      - name: Install flutter
-        uses: subosito/flutter-action@v2
-        with:
-          flutter-version: '3.24.1'
-
-      - name: Check out code
-        uses: actions/checkout@v3
-
-      - name: install dependencies
-        run: |
-          go install golang.org/x/mobile/cmd/gomobile@latest
-          gomobile init
-          flutter pub get
-          touch env.sh
-      
-      - name: Build iOS
-        run: |
-          cd ios
-          pod install
-          xcodebuild -workspace Runner.xcworkspace -scheme Runner -configuration Release clean archive CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO -archivePath "build/MobileNebula.xcarchive"

ios/NebulaNetworkExtension/Site.swift

@@ -488,7 +488,7 @@ struct IncomingSite: Codable {
     private func finishSaveToManager(manager: NETunnelProviderManager, callback: @escaping (Error?) -> ()) {
         // Stuff our details in the protocol
         let proto = manager.protocolConfiguration as? NETunnelProviderProtocol ?? NETunnelProviderProtocol()
-        proto.providerBundleIdentifier = "net.defined.mobileNebula.NebulaNetworkExtension";
+
         proto.providerConfiguration = ["id": self.id]
         proto.serverAddress = "Nebula"
 

nebula/Makefile

@@ -9,7 +9,7 @@ clean:
 
 mobileNebula.aar: *.go go.sum
 	go get -d golang.org/x/mobile/cmd/gomobile
-	gomobile bind -trimpath -v --target=android -androidapi=26
+	gomobile bind -trimpath -v --target=android -androidapi 26
 
 MobileNebula.xcframework: *.go go.sum
 	go get -d golang.org/x/mobile/cmd/gomobile