37 lines
2.4 KiB
Diff
37 lines
2.4 KiB
Diff
From 5f33e6c078a1af6a8a61615eda853205adf22009 Mon Sep 17 00:00:00 2001
|
|
From: BillyGalbreath <Blake.Galbreath@GMail.com>
|
|
Date: Fri, 7 Sep 2018 18:28:24 -0500
|
|
Subject: [PATCH] Fix #1420
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/EntityArrow.java b/src/main/java/net/minecraft/server/EntityArrow.java
|
|
index 66e574bd3..a72d3dcc6 100644
|
|
--- a/src/main/java/net/minecraft/server/EntityArrow.java
|
|
+++ b/src/main/java/net/minecraft/server/EntityArrow.java
|
|
@@ -492,7 +492,9 @@ public abstract class EntityArrow extends Entity implements IProjectile {
|
|
if (!this.world.isClientSide && (this.inGround || this.q()) && this.shake <= 0) {
|
|
// CraftBukkit start
|
|
ItemStack itemstack = this.getItemStack();
|
|
- EntityItem item = new EntityItem(this.world, this.locX, this.locY, this.locZ, itemstack);
|
|
+ EntityItem item = null; // Paper - GH-1420 - allow using event item
|
|
+ if (!itemstack.isEmpty()) { // Paper - GH-1420 (skip pick up event for fully damaged (or air) itemstack)
|
|
+ item = new EntityItem(this.world, this.locX, this.locY, this.locZ, itemstack); // Paper - GH-1420 - allow using event item
|
|
if (this.fromPlayer == PickupStatus.ALLOWED && entityhuman.inventory.canHold(itemstack) > 0) {
|
|
PlayerPickupArrowEvent event = new PlayerPickupArrowEvent((org.bukkit.entity.Player) entityhuman.getBukkitEntity(), new org.bukkit.craftbukkit.entity.CraftItem(this.world.getServer(), this, item), (org.bukkit.entity.Arrow) this.getBukkitEntity());
|
|
// event.setCancelled(!entityhuman.canPickUpLoot); TODO
|
|
@@ -502,9 +504,10 @@ public abstract class EntityArrow extends Entity implements IProjectile {
|
|
return;
|
|
}
|
|
}
|
|
+ } // Paper - GH-1420
|
|
boolean flag = this.fromPlayer == EntityArrow.PickupStatus.ALLOWED || this.fromPlayer == EntityArrow.PickupStatus.CREATIVE_ONLY && entityhuman.abilities.canInstantlyBuild || this.q() && this.getShooter().getUniqueID() == entityhuman.getUniqueID();
|
|
|
|
- if (this.fromPlayer == EntityArrow.PickupStatus.ALLOWED && !entityhuman.inventory.pickup(item.getItemStack())) {
|
|
+ if (this.fromPlayer == EntityArrow.PickupStatus.ALLOWED && !entityhuman.inventory.pickup(item != null ? item.getItemStack() : itemstack)) { // Paper - GH-1420
|
|
// CraftBukkit end
|
|
flag = false;
|
|
}
|
|
--
|
|
2.19.2
|
|
|