From d5fd96d447dd6f8d8fa433d18082329fea603982 Mon Sep 17 00:00:00 2001 From: Minecrell Date: Thu, 21 Sep 2017 16:14:13 +0200 Subject: [PATCH] Handle plugin prefixes in implementation logging configuration Currently, plugin prefixes are prepended to the log message in the PluginLogger before passing the message to the underlying logging framework. This is bad design because they need to be stripped manually when using custom appenders to log messages in a different format. Additionally, it makes integration of alternative logging APIs hard because all logging must go through the PluginLogger. Avoid using PluginLogger and create a regular logger using the plugin name. The implementation should handle plugin prefixes by displaying logger names when appropriate. diff --git a/src/main/java/org/bukkit/plugin/java/JavaPlugin.java b/src/main/java/org/bukkit/plugin/java/JavaPlugin.java index 22319005..bb2e55e9 100644 --- a/src/main/java/org/bukkit/plugin/java/JavaPlugin.java +++ b/src/main/java/org/bukkit/plugin/java/JavaPlugin.java @@ -42,7 +42,7 @@ public abstract class JavaPlugin extends PluginBase { private boolean naggable = true; private FileConfiguration newConfig = null; private File configFile = null; - private PluginLogger logger = null; + private Logger logger = null; // Paper - PluginLogger -> Logger public JavaPlugin() { final ClassLoader classLoader = this.getClass().getClassLoader(); @@ -276,7 +276,8 @@ public abstract class JavaPlugin extends PluginBase { this.dataFolder = dataFolder; this.classLoader = classLoader; this.configFile = new File(dataFolder, "config.yml"); - this.logger = new PluginLogger(this); + // Paper - Handle plugin prefix in implementation + this.logger = Logger.getLogger(description.getPrefix() != null ? description.getPrefix() : description.getName()); } /** -- 2.25.0.windows.1