Commit Graph

2827 Commits

Author SHA1 Message Date
Thinkofdeath 21656db5d1 Fix ConcurrentModificationException while being idle kicked in a vehicle 2014-01-14 20:14:36 +00:00
md_5 af480b8b95 Revert previous change to clear chunk list on the end of each tick, make it configurable instead.
Whilst the new behaviour was technically correct as it prevented the possibility of the chunk tick list actually increasing over time, it introduced a few issues, namely the fact that it slowed growth to unreasonable levels, and interfered with the values which server admins have finally tuned, and come to enjoy over the last few years.
If it is absolutely essential that growth be halted and ticking reduced as much as possible, the config option is there for power users.
If we wish to 'fix' this by default in the future, a new chunk ticking algorithm, which actually has meaningful config options should be designed.
2014-01-14 19:16:43 +11:00
md_5 0add6ac4af Tweak tab complete disabled to only disable completion of the /command section, and not any subsequent arguments to the command, such as player names or plugin provided completions. 2014-01-13 08:57:22 +11:00
md_5 83c105ef02 Remove accidentally added code 2014-01-13 08:28:17 +11:00
md_5 58dc769bb5 Replace AutoSave Mechanism
The problem here is that MinecraftServer.save(..), will attempt to sleep whilst all pending chunks are written to disk, however due to various and complicated bugs, it will wait for an incorrect amount of chunks, which may cause it to sleep for an overly long amount of time. Instead we will mimic the save-all command in its behaviour, which is both safe and performant.
2014-01-12 21:07:27 +11:00
md_5 8bfd4a8ccb Add more code to try and Debug [Mojang] Crash Reports Crashing 2014-01-12 20:56:59 +11:00
md_5 acd5d21a06 Take 2 at fixing unbreakable code 2014-01-10 15:39:36 +11:00
md_5 1220314f79 Fix ItemStack Unbreakable Code.
This code needs brackets to be compiled correctly.
2014-01-10 15:17:23 +11:00
Thinkofdeath afe4189e46 Fix anvil collisions
This fixes the server incorrectly moving the player out of an anvil when touching it on the side. The server used the rotation of the last placed anvil instead the of the rotation of the anvil the player was touching.
2014-01-09 14:28:04 +00:00
Thinkofdeath 4ed5d54dde Allow statistics to be disabled/forced 2014-01-08 22:43:39 +00:00
md_5 1e8cb6d468 Update Client's Hand when BlockPlaceEvent Cancelled
Send a Packet103SetSlot to client when a BlockPlaceEvent is cancelled.

Fixes BUKKIT-5284

Currently, whenever a player places a block in a protected area the
equipped itemstack size on client is never updated properly since the
client thinks the block was placed. The reason this happens is because
ItemStack.matches returns true since the server does not decrement stack
size if a BlockPlaceEvent is cancelled. This causes
PlayerConnection.a(handlePlace) not to send the appropriate packet to
client which causes the bug.
2014-01-08 14:45:45 +11:00
md_5 92db88d292 Update Chest Animation when Cancelling Event
Update chest animation after cancelling InventoryOpenEvent. Fixes BUKKIT-1440

Currently if a plugin cancels an InventoryOpenEvent for vanilla chests,
the chest animation for clients is stuck in the open state since
IInventory's closeChest method is never called. To fix the issue, closeChest
is called before exiting the display GUI method.
More info can be found here
https://bukkit.atlassian.net/browse/BUKKIT-1440
2014-01-08 14:44:50 +11:00
md_5 7e43d71c76 Clear chunkTickList at the end of every tick. 2014-01-08 14:38:38 +11:00
md_5 6c0c101bff Fix orebfuscator startup message showing hide blocks instead of replace blocks 2014-01-06 11:38:59 +11:00
md_5 cd0c975a6d Fix Biome Decoration Crashes
We don't really know what affect this will have on the terrain generation, but its better than crashing and not having terrain generate at all!
2014-01-05 09:35:15 +11:00
Thinkofdeath 885ae9871e Disconnect for spam in the main thread 2014-01-03 17:33:41 +00:00
Thinkofdeath 9f71f7e3db Handle different sizes (G,K) for the PermGen warning 2013-12-28 23:54:44 +00:00
Thinkofdeath 2b8293489e Fix Effect.TILE_BREAK
The particle's name got changed with @Grum 's tile -> block rename
2013-12-27 19:45:04 +00:00
md_5 12a1363cea Revert "Use Entity.teleportTo in CraftEntity.teleport"
This reverts commit adaf7c3ae8.
2013-12-24 14:52:45 +11:00
slide23 4fd3ddc33e Add Late Bind Option
Add late-bind config option to delay binding until loading is done.
2013-12-24 10:22:53 +11:00
Andrew Krieger adaf7c3ae8 Use Entity.teleportTo in CraftEntity.teleport
Entity.teleportTo is largely stable and correct. CraftEntity.teleport,
however, still cannot properly handle cross-world teleportation. Fix it
to defer to the better code in core Minecraft.
2013-12-24 10:18:01 +11:00
md_5 db8db0b36b Fix tab completion for some Vanilla commands (reload, plugins, testfor, tell) Thanks @ams2990 2013-12-24 10:14:53 +11:00
md_5 d072f55caa Revert the revert for now. 2013-12-23 21:03:39 +11:00
md_5 624acbd0c8 Increase verbosity of watchdog dumps 2013-12-23 21:01:45 +11:00
md_5 cad440b56a Revert check pending blocks patch as it (may) be causing some crash issues 2013-12-23 20:19:37 +11:00
md_5 f7086eb96d Disable connected check on setScoreboard. Mojang's semi async Netty implementation can lead to race conditions, and this exception being thrown when it really shouldn't. 2013-12-23 15:58:41 +11:00
md_5 45bbe59c15 Fix missing bitshifts 2013-12-23 15:43:33 +11:00
md_5 16467dc148 Warn if PermGen may be insufficient. Since 1.7 Mojang added a lot of new classes to their jar. This, coupled with plugins, may cause the loaded classes to exceed the default perm gem of 64mb. As such we will print a small warning advising users to set a higher PermGen if they haven't already. 2013-12-23 14:08:28 +11:00
Dan Mulloy 9272a671f7 Fix Biome Decoration Crashes 2013-12-23 11:18:44 +11:00
md_5 b32968b9a0 Add option to nerfs mobs from spawners. When this option is enabled, mobs which originate from a mob spawner will not have any AI, ie: brains. They will generally only be affected by water movement, with the exception of blazes which will still emit fireballs and float up and down.
This is disabled by default as it has a strong behavioural impact.
2013-12-22 21:02:55 +11:00
md_5 7b87ab6548 Add the getCubes patch back. Turns out the user with lockups had 23k+ entities in a single chunk. 2013-12-22 10:41:48 +11:00
md_5 6a98142bd5 Fix patch tree. 2013-12-22 10:06:06 +11:00
md_5 31c9311b07 Redo previous getCubes removal. 2013-12-22 10:05:27 +11:00
md_5 7890d0a442 Fix patches some more. 2013-12-22 10:04:44 +11:00
md_5 b47555dc7a Revert "Remove getCubes patch as under some circumstances it can loop around itself forever. For anyone wishing to reimplement this patch, the rationale behind it is quite simple, get all cubes within each chunk at the same time."
This reverts commit 06233ce472.
2013-12-22 10:03:57 +11:00
DerFlash 78bc1384a7 Save ticks lived to nbttag 2013-12-22 10:00:13 +11:00
md_5 06233ce472 Remove getCubes patch as under some circumstances it can loop around itself forever. For anyone wishing to reimplement this patch, the rationale behind it is quite simple, get all cubes within each chunk at the same time. 2013-12-22 09:59:17 +11:00
md_5 2549f4c043 Force Load Chunks for Biome Decoration. May solve some random.nextInt() crashes people have been seeing. 2013-12-21 20:08:42 +11:00
md_5 b42275d94c Fix accidentally reverted mc-dev imports. 2013-12-21 19:14:34 +11:00
md_5 1c099a713b Upstream merge, nothing major. 2013-12-21 19:13:39 +11:00
Thinkofdeath ed2fd14801 Re-add the particle API 2013-12-20 21:37:22 +00:00
md_5 a1c8965df5 Stage BiomeDecorator so we can get line numbers to match for stack traces. 2013-12-19 17:45:12 +11:00
Thinkofdeath ee8495a246 Allow the console to use vanilla commands 2013-12-18 11:40:35 +00:00
md_5 8278880f0f Fall back to our own URL clicking method as it works with more cases. 2013-12-18 20:41:42 +11:00
md_5 e9cb6ec3c5 Upstream merge 2013-12-18 17:48:18 +11:00
md_5 fe00a77ac8 Invert command complete check 2013-12-18 17:24:24 +11:00
md_5 4978db4332 Log Cause of Unexpected Exceptions 2013-12-18 13:39:28 +11:00
md_5 61400aa00c Fire PreLogin Events in Offline Mode 2013-12-18 13:32:30 +11:00
Thinkofdeath eafbb2a4c1 Add VanillaCommandWrapper which allows use of vanilla commands instead of Bukkit's versions 2013-12-18 10:33:58 +11:00
frymaster bd5e1fbba9 Remove references to chunklist
Commit c576054539790bdeb35285f62863d74b48c0782d removed the chunklist collection stored in ChunkProviderServer, however it has been partially restored in some places by 7e1ac0a77129b169704c1e222ff2deb3ab6cd2d2.  As not all references to this were restored, this has caused the chunklist and chunks collections to become out of sync, resulting in a memory leak.
2013-12-18 09:30:21 +11:00