testserver

3,071 Commits 1 Branch 0 Tags 60 MiB

Author	SHA1	Message	Date
Minecrell	5b6c59009b	Improve backward compatibility of deprecated player sample API (#1065 ) Some plugins (e.g. older builds of EssentialsX) assume that ServerListPingEvent.getSampleText() returns a mutable copy of the player sample list. This was the case until it was refactored on top of the new API introduced in #980. As a result, they may run into an error when trying to modify the returned list directly. Modify getSampleText() to return a mutable copy (a plain ArrayList) to mimic the old behavior.	2018-03-26 17:45:18 -04:00
Aikar	cff8ae9644	Use copies for PlayerProfile in PaperServerList and SkullMeta Don't want to risk mutating players properties in server list (unlikely, but lets be proper) and Skull also has a setter API, so that should be used too.	2018-03-22 23:32:55 -04:00

Author

SHA1

Message

Date

Minecrell

5b6c59009b

Improve backward compatibility of deprecated player sample API (#1065 )

Some plugins (e.g. older builds of EssentialsX) assume that
ServerListPingEvent.getSampleText() returns a mutable copy of
the player sample list. This was the case until it was refactored
on top of the new API introduced in #980.

As a result, they may run into an error when trying to modify the
returned list directly. Modify getSampleText() to return a mutable
copy (a plain ArrayList) to mimic the old behavior.

2018-03-26 17:45:18 -04:00

Aikar

cff8ae9644

Use copies for PlayerProfile in PaperServerList and SkullMeta

Don't want to risk mutating players properties in server list (unlikely, but lets be proper)

and Skull also has a setter API, so that should be used too.

2018-03-22 23:32:55 -04:00

Renamed from Spigot-API-Patches/0090-Implement-deprecated-player-sample-API.patch (Browse further)

2 Commits