testserver

Commit Graph

Author	SHA1	Message	Date
Zach Brown	10469dfd46	Remove TE Fixer changes Ultimately they should be unnecessary now that upstream's fix has been in place for a while. Removing this reduces our own footprint, and gets rid of any possible unintended behavior.	2016-10-05 15:46:44 -05:00
Aikar	501695c26a	Process NMS Data Conversion post ItemMeta on Copy ItemMeta apply is a destructive process that expects to be the authority on what the items NBT data is. When CraftItemStack.asNMSCopy was called, the conversion ran, potentially setting the converted data into the ItemStacks tag. Then if that item had ItemMeta, it would completely undo that conversion by erasing the NBT Tag. On copy, run conversion post ItemMeta apply.	2016-09-21 23:42:13 -04:00

Author

SHA1

Message

Date

Zach Brown

10469dfd46

Remove TE Fixer changes

Ultimately they should be unnecessary now that upstream's fix has been
in place for a while. Removing this reduces our own footprint, and gets
rid of any possible unintended behavior.

2016-10-05 15:46:44 -05:00

Aikar

501695c26a

Process NMS Data Conversion post ItemMeta on Copy

ItemMeta apply is a destructive process that expects to be the authority on
what the items NBT data is.

When CraftItemStack.asNMSCopy was called, the conversion ran, potentially setting
the converted data into the ItemStacks tag.

Then if that item had ItemMeta, it would completely undo that conversion by
erasing the NBT Tag.

On copy, run conversion post ItemMeta apply.

2016-09-21 23:42:13 -04:00

2 Commits