testserver

Commit Graph

Author	SHA1	Message	Date
Shane Freeder	0f97922ebd	Restore broken lighting logic from spigot	2017-12-18 07:35:42 +00:00
Brokkonaut	8835dcc6f4	Replace HashSet with fastutil's ObjectOpenHashSet in HashTreeSet HashSet sometimes uses compareTo() instead of equals() and this breaks the comparison of net.minecraft.server.NextTickListEntry (the only place where HashTreeSet is used). In this cases duplicate entries could be added to the HashSet of HashTreeSet, because NextTickListEntry.compareTo() does not return 0, even if NextTickListEntry.equals() returns true. ObjectOpenHashSet never uses compareTo(), so the inconsistencies of NextTickListEntry cause no problems. Fixes https://github.com/PaperMC/Paper/issues/588	2017-10-29 15:35:16 +00:00

Author

SHA1

Message

Date

Shane Freeder

0f97922ebd

Restore broken lighting logic from spigot

2017-12-18 07:35:42 +00:00

Brokkonaut

8835dcc6f4

Replace HashSet with fastutil's ObjectOpenHashSet in HashTreeSet

HashSet sometimes uses compareTo() instead of equals() and this breaks the comparison of net.minecraft.server.NextTickListEntry (the only place where HashTreeSet is used).

In this cases duplicate entries could be added to the HashSet of HashTreeSet, because NextTickListEntry.compareTo() does not return 0, even if NextTickListEntry.equals() returns true.

ObjectOpenHashSet never uses compareTo(), so the inconsistencies of NextTickListEntry cause no problems.

Fixes https://github.com/PaperMC/Paper/issues/588

2017-10-29 15:35:16 +00:00

2 Commits