From c8055836e8a867397f5c324178a7e3becb02d653 Mon Sep 17 00:00:00 2001 From: Aikar Date: Sat, 23 May 2020 17:35:27 -0400 Subject: [PATCH] Update Netty to 4.1.51 Minecraft's Netty version was severely out of date. There has been numerous security fixes, bug fixes, and likely performance fixes since the version Minecraft uses (4.1.25). This fixes some known issues with "Closed Channel" spam. Fixes #3388 --- Spigot-Server-Patches/0001-POM-Changes.patch | 35 ++++++++++++++----- ...oleAppender-for-console-improvements.patch | 4 +-- .../0501-Implement-Mob-Goal-API.patch | 4 +-- 3 files changed, 31 insertions(+), 12 deletions(-) diff --git a/Spigot-Server-Patches/0001-POM-Changes.patch b/Spigot-Server-Patches/0001-POM-Changes.patch index f157e4910..6d7760c63 100644 --- a/Spigot-Server-Patches/0001-POM-Changes.patch +++ b/Spigot-Server-Patches/0001-POM-Changes.patch @@ -5,7 +5,7 @@ Subject: [PATCH] POM Changes diff --git a/pom.xml b/pom.xml -index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf0ab41504 100644 +index 9fc92e347f24a0210a9190513e93cba3b6772557..aec55b0b78fa47d427652d402cfbb61295672b11 100644 --- a/pom.xml +++ b/pom.xml @@ -1,15 +1,14 @@ @@ -55,7 +55,7 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf ${project.version} compile -@@ -50,6 +55,12 @@ +@@ -50,6 +55,17 @@ 7.3.1 compile @@ -64,11 +64,16 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf + co.aikar + cleaner + 1.0-SNAPSHOT ++ ++ ++ io.netty ++ netty-all ++ 4.1.51.Final-SNAPSHOT + com.googlecode.json-simple -@@ -106,34 +117,22 @@ +@@ -106,34 +122,22 @@ @@ -114,7 +119,7 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf -@@ -143,6 +142,7 @@ +@@ -143,6 +147,7 @@ maven-jar-plugin 3.2.0 @@ -122,7 +127,7 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf false -@@ -150,8 +150,9 @@ +@@ -150,8 +155,9 @@ org.bukkit.craftbukkit.Main CraftBukkit @@ -134,7 +139,7 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf Bukkit ${api.version} Bukkit Team -@@ -190,6 +191,7 @@ +@@ -190,6 +196,7 @@ shade @@ -142,7 +147,21 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf ${shadeSourcesJar} -@@ -213,10 +215,11 @@ +@@ -198,6 +205,13 @@ + com/google/common/** + com/google/gson/** + com/google/thirdparty/** ++ ++ io/netty/** ++ com/brigadier/** ++ META-INF/MANIFEST.MF ++ com.mojang.authlib.yggdrasil.YggdrasilGameProfileRepository ++ com.mojang.datafixers.util.Either ++ org.apache.logging.log4j/** + + + +@@ -213,10 +227,11 @@ jline org.bukkit.craftbukkit.libs.jline @@ -158,7 +177,7 @@ index 9fc92e347f24a0210a9190513e93cba3b6772557..adf32845001fae7a870f588184c2efaf org.apache.commons.codec org.bukkit.craftbukkit.libs.org.apache.commons.codec -@@ -258,10 +261,6 @@ +@@ -258,10 +273,6 @@ org.apache.maven.plugins maven-compiler-plugin 3.8.1 diff --git a/Spigot-Server-Patches/0148-Use-TerminalConsoleAppender-for-console-improvements.patch b/Spigot-Server-Patches/0148-Use-TerminalConsoleAppender-for-console-improvements.patch index e8bbad1b1..74d21b289 100644 --- a/Spigot-Server-Patches/0148-Use-TerminalConsoleAppender-for-console-improvements.patch +++ b/Spigot-Server-Patches/0148-Use-TerminalConsoleAppender-for-console-improvements.patch @@ -19,7 +19,7 @@ Other changes: configuration diff --git a/pom.xml b/pom.xml -index adf32845001fae7a870f588184c2efaf0ab41504..d07ec94d3011eca8b986e45a63d0c6392691b273 100644 +index aec55b0b78fa47d427652d402cfbb61295672b11..48f5ed765cab101633efdcdd9118fd3cb5f97914 100644 --- a/pom.xml +++ b/pom.xml @@ -44,10 +44,27 @@ @@ -54,7 +54,7 @@ index adf32845001fae7a870f588184c2efaf0ab41504..d07ec94d3011eca8b986e45a63d0c639 org.ow2.asm -@@ -252,10 +269,18 @@ +@@ -264,10 +281,18 @@ META-INF/services/java.sql.Driver diff --git a/Spigot-Server-Patches/0501-Implement-Mob-Goal-API.patch b/Spigot-Server-Patches/0501-Implement-Mob-Goal-API.patch index b5b2b654a..0884ba61e 100644 --- a/Spigot-Server-Patches/0501-Implement-Mob-Goal-API.patch +++ b/Spigot-Server-Patches/0501-Implement-Mob-Goal-API.patch @@ -5,10 +5,10 @@ Subject: [PATCH] Implement Mob Goal API diff --git a/pom.xml b/pom.xml -index 60bf6dd28527f6ffcb59779ec9546030245724ca..1ae57e8ab2681e674f97ef3220c5cbf9143c6a7e 100644 +index 389fdcf45eb1513bd6f7f1f0974ace6c00976c2c..84c54a32af54f8460da3257f4423dfcee558e171 100644 --- a/pom.xml +++ b/pom.xml -@@ -128,6 +128,13 @@ +@@ -133,6 +133,13 @@ 1.3 test