core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SPIGOT-3699: Fix cloning banner itemstacks 

the banner meta would end up with a shared reference to the patterns
This commit is contained in:
Aikar 2017-12-15 15:57:15 -05:00
parent f9c8c9eecf
commit b8833f477c
No known key found for this signature in database
GPG Key ID: 401ADFC9891FAAFE
1 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Spigot-Server-Patches/0258-Fix-cloning-banner-itemstacks.patch Normal file
View File

@ -0,0 +1,29 @@
From d8ba17b1464eb0fe35132f092a972c8b97adeeb1 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Fri, 15 Dec 2017 15:52:28 -0500
Subject: [PATCH] Fix cloning banner itemstacks
the banner meta would end up with a shared reference to the patterns
diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBanner.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBanner.java
index aa1a210a2..3ae4604f0 100644
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBanner.java
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBanner.java
@@ -200,4 +200,14 @@ public class CraftMetaBanner extends CraftMetaItem implements BannerMeta {
boolean applicableTo(Material type) {
return type == Material.BANNER;
}
+
+ // Paper start
+ @Override
+ public CraftMetaBanner clone() {
+ CraftMetaBanner clone = (CraftMetaBanner) super.clone();
+ clone.base = this.base;
+ clone.patterns = new ArrayList<>(this.patterns);
+ return clone;
+ }
+ // Paper end
}
--
2.15.1