2019-04-22 21:36:14 +00:00
|
|
|
From f88a68c596f190756119dec505888c50d543fc1b Mon Sep 17 00:00:00 2001
|
2018-07-28 16:13:52 +00:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Sat, 28 Jul 2018 12:09:20 -0400
|
|
|
|
Subject: [PATCH] Always process chunk removal in removeEntity
|
|
|
|
|
|
|
|
Spigot might skip chunk registration changes in removeEntity
|
|
|
|
which can keep them in the chunk when they shouldnt be if done
|
|
|
|
during entity ticking.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
2019-04-06 03:08:45 +00:00
|
|
|
index 1929e9d2ae..1cbe6e17b7 100644
|
2018-07-28 16:13:52 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
2019-04-06 03:08:45 +00:00
|
|
|
@@ -1107,13 +1107,14 @@ public abstract class World implements IEntityAccess, GeneratorAccess, IIBlockAc
|
2018-07-28 16:13:52 +00:00
|
|
|
this.everyoneSleeping();
|
|
|
|
}
|
|
|
|
|
|
|
|
- if (!guardEntityList) { // Spigot - It will get removed after the tick if we are ticking
|
|
|
|
+ // if (!guardEntityList) { // Spigot - It will get removed after the tick if we are ticking // Paper - move down
|
2018-12-17 05:18:06 +00:00
|
|
|
int i = entity.chunkX;
|
|
|
|
int j = entity.chunkZ;
|
2018-07-28 16:13:52 +00:00
|
|
|
|
2019-04-06 03:08:45 +00:00
|
|
|
Chunk chunk = entity.getCurrentChunk(); // Paper
|
|
|
|
if (chunk != null) chunk.removeEntity(entity); // Paper
|
2018-07-28 16:13:52 +00:00
|
|
|
|
|
|
|
+ if (!guardEntityList) { // Spigot - It will get removed after the tick if we are ticking // Paper - always remove from current chunk above
|
|
|
|
// CraftBukkit start - Decrement loop variable field if we've already ticked this entity
|
|
|
|
int index = this.entityList.indexOf(entity);
|
|
|
|
if (index != -1) {
|
|
|
|
--
|
2019-03-20 01:46:00 +00:00
|
|
|
2.21.0
|
2018-07-28 16:13:52 +00:00
|
|
|
|