core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0181-Optimize-ItemStack.isE...

32 lines
1.4 KiB
Diff
Raw Normal View History

Current Chunk for Entity and Block Entities, counts by entity type This enables us a fast reference to the entities current chunk instead of having to look it up by hashmap lookups. We also store counts by type to further enable other performance optimizations in later patches.
2018-07-04 07:55:24 +00:00
From a1b931dcc9fc5937954696bacf2349dcc5b9d57a Mon Sep 17 00:00:00 2001
Optimize isEmpty() to remove Map lookup Every call to .isEmpty() made a horribly wasteful map lookup just to get the reference to the Air Item for checking. We will now cache a copy of that item
2016-12-21 09:21:42 +00:00
From: Aikar <aikar@aikar.co>
Date: Wed, 21 Dec 2016 03:48:29 -0500
Subject: [PATCH] Optimize ItemStack.isEmpty()
Remove hashMap lookup every check, simplify code to remove ternary
diff --git a/src/main/java/net/minecraft/server/ItemStack.java b/src/main/java/net/minecraft/server/ItemStack.java
LivingEntity Hand Raised/Item Use API How long an entity has raised hands to charge an attack or use an item Also aliased isHandsRaised for isChargingAttack in RangedEntity
2018-06-29 04:55:29 +00:00
index 5047a57e9..736686bed 100644
Optimize isEmpty() to remove Map lookup Every call to .isEmpty() made a horribly wasteful map lookup just to get the reference to the Air Item for checking. We will now cache a copy of that item
2016-12-21 09:21:42 +00:00
--- a/src/main/java/net/minecraft/server/ItemStack.java
+++ b/src/main/java/net/minecraft/server/ItemStack.java
LivingEntity Hand Raised/Item Use API How long an entity has raised hands to charge an attack or use an item Also aliased isHandsRaised for isChargingAttack in RangedEntity
2018-06-29 04:55:29 +00:00
@@ -144,9 +144,15 @@ public final class ItemStack {
Optimize isEmpty() to remove Map lookup Every call to .isEmpty() made a horribly wasteful map lookup just to get the reference to the Air Item for checking. We will now cache a copy of that item
2016-12-21 09:21:42 +00:00
this.F();
}
+ // Paper start - optimize isEmpty
+ private static Item airItem;
public boolean isEmpty() {
- return this == ItemStack.a ? true : (this.item != null && this.item != Item.getItemOf(Blocks.AIR) ? (this.count <= 0 ? true : this.damage < -32768 || this.damage > '\uffff') : true);
+ if (airItem == null) {
+ airItem = Item.REGISTRY.get(new MinecraftKey("air"));
+ }
+ return this == ItemStack.a || this.item == null || this.item == airItem || (this.count <= 0 || (this.damage < -32768 || this.damage > '\uffff'));
}
+ // Paper end
public static void a(DataConverterManager dataconvertermanager) {
dataconvertermanager.a(DataConverterTypes.ITEM_INSTANCE, (DataInspector) (new DataInspectorBlockEntity()));
--
LivingEntity Hand Raised/Item Use API How long an entity has raised hands to charge an attack or use an item Also aliased isHandsRaised for isChargingAttack in RangedEntity
2018-06-29 04:55:29 +00:00
2.18.0
Optimize isEmpty() to remove Map lookup Every call to .isEmpty() made a horribly wasteful map lookup just to get the reference to the Air Item for checking. We will now cache a copy of that item
2016-12-21 09:21:42 +00:00