testserver/Spigot-Server-Patches/0054-Add-exception-reportin...

287 lines
16 KiB
Diff
Raw Normal View History

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2016-02-29 01:15:51 +00:00
From: Joseph Hirschfeld <joe@ibj.io>
2016-02-29 23:09:49 +00:00
Date: Thu, 3 Mar 2016 03:15:41 -0600
2016-02-29 01:15:51 +00:00
Subject: [PATCH] Add exception reporting event
2016-02-29 23:09:49 +00:00
diff --git a/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java b/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java
new file mode 100644
index 0000000000000000000000000000000000000000..f699ce18ca044f813e194ef2786b7ea853ea86e7
2016-02-29 23:09:49 +00:00
--- /dev/null
+++ b/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java
@@ -0,0 +1,38 @@
+package com.destroystokyo.paper;
+
+import com.google.common.base.Preconditions;
+import org.bukkit.craftbukkit.scheduler.CraftTask;
+import com.destroystokyo.paper.event.server.ServerExceptionEvent;
+import com.destroystokyo.paper.exception.ServerSchedulerException;
+
+/**
+ * Reporting wrapper to catch exceptions not natively
+ */
+public class ServerSchedulerReportingWrapper implements Runnable {
+
+ private final CraftTask internalTask;
+
+ public ServerSchedulerReportingWrapper(CraftTask internalTask) {
+ this.internalTask = Preconditions.checkNotNull(internalTask, "internalTask");
+ }
+
+ @Override
+ public void run() {
+ try {
+ internalTask.run();
+ } catch (RuntimeException e) {
+ internalTask.getOwner().getServer().getPluginManager().callEvent(
+ new ServerExceptionEvent(new ServerSchedulerException(e, internalTask))
+ );
+ throw e;
+ } catch (Throwable t) {
+ internalTask.getOwner().getServer().getPluginManager().callEvent(
+ new ServerExceptionEvent(new ServerSchedulerException(t, internalTask))
+ ); //Do not rethrow, since it is not permitted with Runnable#run
+ }
+ }
+
+ public CraftTask getInternalTask() {
+ return internalTask;
+ }
+}
2016-02-29 01:15:51 +00:00
diff --git a/src/main/java/net/minecraft/server/Chunk.java b/src/main/java/net/minecraft/server/Chunk.java
2020-06-25 11:00:35 +00:00
index a803d1093dfa7c7421eda913679766224fda6dcf..3ade9a83f750854cd5663a6a177fe27eaac73c39 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/Chunk.java
+++ b/src/main/java/net/minecraft/server/Chunk.java
2016-02-29 23:09:49 +00:00
@@ -1,5 +1,6 @@
package net.minecraft.server;
+import com.destroystokyo.paper.exception.ServerInternalException;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
2019-04-26 01:24:00 +00:00
import it.unimi.dsi.fastutil.longs.LongOpenHashSet;
2020-06-25 11:00:35 +00:00
@@ -613,10 +614,15 @@ public class Chunk implements IChunkAccess {
2016-02-29 01:15:51 +00:00
this.tileEntities.remove(blockposition);
2016-02-29 23:09:49 +00:00
// Paper end
2016-02-29 01:15:51 +00:00
} else {
- System.out.println("Attempted to place a tile entity (" + tileentity + ") at " + tileentity.position.getX() + "," + tileentity.position.getY() + "," + tileentity.position.getZ()
- + " (" + getType(blockposition) + ") where there was no entity tile!");
2019-04-26 01:24:00 +00:00
- System.out.println("Chunk coordinates: " + (this.loc.x * 16) + "," + (this.loc.z * 16));
2016-02-29 01:15:51 +00:00
- new Exception().printStackTrace();
+ // Paper start
+ ServerInternalException e = new ServerInternalException(
+ "Attempted to place a tile entity (" + tileentity + ") at " + tileentity.position.getX() + ","
2016-02-29 23:09:49 +00:00
+ + tileentity.position.getY() + "," + tileentity.position.getZ()
2019-04-26 01:24:00 +00:00
+ + " (" + getType(blockposition) + ") where there was no entity tile!\n" +
+ "Chunk coordinates: " + (this.loc.x * 16) + "," + (this.loc.z * 16));
2016-02-29 01:15:51 +00:00
+ e.printStackTrace();
+ ServerInternalException.reportInternalException(e);
+ // Paper end
// CraftBukkit end
}
}
diff --git a/src/main/java/net/minecraft/server/ChunkProviderServer.java b/src/main/java/net/minecraft/server/ChunkProviderServer.java
2020-06-25 11:00:35 +00:00
index 7dd9c5eec53631d25ae511b1e57bdadfe28ce289..7abd3683f9cc21b90dc74739954de2decddf6478 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/ChunkProviderServer.java
+++ b/src/main/java/net/minecraft/server/ChunkProviderServer.java
2020-06-25 11:00:35 +00:00
@@ -17,6 +17,9 @@ import java.util.function.Consumer;
2019-05-14 02:20:58 +00:00
import java.util.function.Function;
2019-04-26 01:24:00 +00:00
import java.util.function.Supplier;
2016-05-12 02:07:46 +00:00
import javax.annotation.Nullable;
2016-02-29 23:09:49 +00:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2019-04-26 01:24:00 +00:00
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
2016-02-29 01:15:51 +00:00
2019-04-26 01:24:00 +00:00
public class ChunkProviderServer extends IChunkProvider {
2016-02-29 23:09:49 +00:00
2016-02-29 01:15:51 +00:00
diff --git a/src/main/java/net/minecraft/server/NameReferencingFileConverter.java b/src/main/java/net/minecraft/server/NameReferencingFileConverter.java
2020-06-25 11:00:35 +00:00
index bf0ccfb9bf20422b90ef26370d113b49be7d730b..060887d765604e4be82913607bb6266a278f5db6 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/NameReferencingFileConverter.java
+++ b/src/main/java/net/minecraft/server/NameReferencingFileConverter.java
@@ -1,5 +1,6 @@
2016-02-29 23:09:49 +00:00
package net.minecraft.server;
2016-02-29 01:15:51 +00:00
2016-02-29 23:09:49 +00:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2017-05-14 18:05:01 +00:00
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.common.io.Files;
2020-06-25 11:00:35 +00:00
@@ -353,6 +354,7 @@ public class NameReferencingFileConverter {
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Warning: this commit contains more mapping changes from upstream, As always, ensure that you have working backups and test this build before deployment; Developers working on paper will, yet again, need to delete their work/Minecraft/1.13.2 folder Bukkit Changes: 7fca5fd4 SPIGOT-4558: Preserve user order in the face of copied defaults in configurations 15c9b1eb Ignore spurious slot IDs sent by client, e.g. in enchanting tables 5d2a10c5 SPIGOT-3747: Add API for force loaded chunks d6dd2bb3 SPIGOT-3538: Add getHitBlockFace for ProjectileHitEvent 771db4aa SPIGOT-794: Call EntityPlaceEvent for Minecart placement 55462509 Add InventoryView#getSlotType 2f3ce5b6 Remove EntityTransformEvent and CustomItemTagContainer from draft API f04ad7b6 Make ProjectileLaunchEvent extend EntitySpawnEvent ccb85808 Define EntitySpawnEvent b8cc3ebe Add PlayerItemDamageEvent 184a495d Ease ClassLoader Deadlocks Where Possible 11ac4728 Expand Boolean Prompt Values in Conversation API aae62d51 Added getAllSessionData() to the Conversation API. 9290ff91 Add InventoryView#getInventory API 995e530f Add API to get / set base arrow damage CraftBukkit Changes: c4a67eed SPIGOT-4556: Fix plugins closing inventory during drop events 5be2ddcb Replace version constants with methods to prevent compiler inlining a5b9c7b3 Use API method to create offset command completions 2bc7d1df SPIGOT-3747: Add API for force loaded chunks a408f375 SPIGOT-3538: Add getHitBlockFace for ProjectileHitEvent b54b9409 SPIGOT-2864: Make Arrow / Item setTicksLived behave like FallingBlock 79ded7a8 SPIGOT-1811: Death message not shown on respawn screen b4a4f15d SPIGOT-943: InventoryCloseEvent called on death regardless of open inventory 0afed592 SPIGOT-794: Call EntityPlaceEvent for Minecart placement 2b2d084a Add InventoryView#getSlotType 01a9959a Do not use deprecated ItemSpawnEvent constructor 9642498d SPIGOT-4547: Call EntitySpawnEvent as general spawn fallback event 963f4a5f Add PlayerItemDamageEvent 63db0445 Add API to get / set base arrow damage 531c25d7 Add CraftMagicNumbers.MAPPINGS_VERSION for use by NMS plugins d05c8b14 Mappings Update bd36e200 SPIGOT-4551: Ignore invalid attribute modifier slots Spigot Changes: 518206a1 Remove redundant trove depend 1959ad21 MC-11211,SPIGOT-4552: Fix placing double slabs at y = 255 29ab5e43 SPIGOT-3661: Allow arguments in restart-script 7cc46316 SPIGOT-852: Growth modifiers for beetroots, potatoes, carrots 82e117e1 Squelch "fatal: Resolve operation not in progress" message 0a1a68e7 Mappings Update & Patch Rebuild
2019-01-01 03:15:55 +00:00
root = NBTCompressedStreamTools.a(new java.io.FileInputStream(file5));
2016-02-29 01:15:51 +00:00
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
}
if (root != null) {
2020-06-25 11:00:35 +00:00
@@ -366,6 +368,7 @@ public class NameReferencingFileConverter {
2016-02-29 01:15:51 +00:00
NBTCompressedStreamTools.a(root, new java.io.FileOutputStream(file2));
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
}
2016-02-29 23:09:49 +00:00
}
2016-02-29 01:15:51 +00:00
// CraftBukkit end
2019-04-26 01:24:00 +00:00
diff --git a/src/main/java/net/minecraft/server/PlayerChunkMap.java b/src/main/java/net/minecraft/server/PlayerChunkMap.java
index 31d4faebcf34e2e207806d7945e1d8c50c5097bd..2b4033cb2b3d42b776afb9c219d2f64b6c6b1e79 100644
2019-04-26 01:24:00 +00:00
--- a/src/main/java/net/minecraft/server/PlayerChunkMap.java
+++ b/src/main/java/net/minecraft/server/PlayerChunkMap.java
2020-06-25 11:00:35 +00:00
@@ -761,6 +761,7 @@ public class PlayerChunkMap extends IChunkLoader implements PlayerChunk.d {
2019-05-14 02:20:58 +00:00
return true;
2019-04-26 01:24:00 +00:00
} catch (Exception exception) {
PlayerChunkMap.LOGGER.error("Failed to save chunk {},{}", chunkcoordintpair.x, chunkcoordintpair.z, exception);
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(exception); // Paper
2019-05-14 02:20:58 +00:00
return false;
2019-04-26 01:24:00 +00:00
}
}
2016-02-29 01:15:51 +00:00
diff --git a/src/main/java/net/minecraft/server/RegionFile.java b/src/main/java/net/minecraft/server/RegionFile.java
2020-06-25 11:00:35 +00:00
index 1ce85ab949213efb9eae6daddca6ac8fb15dd472..d2977022d163edc5518dd4737c30cffd3eff5954 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/RegionFile.java
+++ b/src/main/java/net/minecraft/server/RegionFile.java
2020-06-25 11:00:35 +00:00
@@ -246,6 +246,7 @@ public class RegionFile implements AutoCloseable {
2019-12-11 02:43:21 +00:00
return true;
2019-04-26 01:24:00 +00:00
}
2019-12-11 02:43:21 +00:00
} catch (IOException ioexception) {
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(ioexception); // Paper
return false;
2016-02-29 01:15:51 +00:00
}
}
2020-06-25 11:00:35 +00:00
@@ -318,6 +319,7 @@ public class RegionFile implements AutoCloseable {
2019-12-11 02:43:21 +00:00
filechannel.write(bytebuffer);
} catch (Throwable throwable1) {
throwable = throwable1;
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(throwable); // Paper
throw throwable1;
} finally {
if (filechannel != null) {
2016-02-29 01:15:51 +00:00
diff --git a/src/main/java/net/minecraft/server/SpawnerCreature.java b/src/main/java/net/minecraft/server/SpawnerCreature.java
2020-06-26 16:20:03 +00:00
index f27ffc56d548c09b7a1fced6d87623d493a21543..e08de74543535072e63ecfc9bd3ada95c9dbfeb7 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/SpawnerCreature.java
+++ b/src/main/java/net/minecraft/server/SpawnerCreature.java
2020-06-25 11:00:35 +00:00
@@ -14,6 +14,7 @@ import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
2016-02-29 23:09:49 +00:00
// CraftBukkit start
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 01:15:51 +00:00
import org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason;
2019-04-26 01:24:00 +00:00
// CraftBukkit end
2016-02-29 01:15:51 +00:00
2020-06-26 16:20:03 +00:00
@@ -268,6 +269,7 @@ public final class SpawnerCreature {
2020-06-25 11:00:35 +00:00
}
} catch (Exception exception) {
SpawnerCreature.LOGGER.warn("Failed to create mob", exception);
+ ServerInternalException.reportInternalException(exception); // Paper
return null;
}
}
2020-06-26 16:20:03 +00:00
@@ -373,6 +375,7 @@ public final class SpawnerCreature {
2020-06-25 11:00:35 +00:00
entity = biomebase_biomemeta.c.a(generatoraccess.getMinecraftWorld());
2016-02-29 01:15:51 +00:00
} catch (Exception exception) {
2019-04-26 01:24:00 +00:00
SpawnerCreature.LOGGER.warn("Failed to create mob", exception);
2016-02-29 01:15:51 +00:00
+ ServerInternalException.reportInternalException(exception); // Paper
continue;
}
diff --git a/src/main/java/net/minecraft/server/VillageSiege.java b/src/main/java/net/minecraft/server/VillageSiege.java
2020-06-25 11:00:35 +00:00
index 045c16654e60f2312e9b6f7b0de2c9e921321201..b1081e441023f5d24091321b1267b5651adeb331 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/VillageSiege.java
+++ b/src/main/java/net/minecraft/server/VillageSiege.java
@@ -1,5 +1,7 @@
package net.minecraft.server;
2016-02-29 23:09:49 +00:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 01:15:51 +00:00
+
import java.util.Iterator;
2016-05-12 02:07:46 +00:00
import javax.annotation.Nullable;
2019-04-26 01:24:00 +00:00
2020-06-25 11:00:35 +00:00
@@ -101,6 +103,7 @@ public class VillageSiege implements MobSpawner {
entityzombie.prepare(worldserver, worldserver.getDamageScaler(entityzombie.getChunkCoordinates()), EnumMobSpawn.EVENT, (GroupDataEntity) null, (NBTTagCompound) null);
2016-02-29 01:15:51 +00:00
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
2019-04-26 01:24:00 +00:00
return;
2016-02-29 01:15:51 +00:00
}
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
2020-06-26 16:20:03 +00:00
index a1e1dc72cd6a556505a6f0d7feee2527947c00dd..c01f0e897ab8741c7fd68245458acdb8559e843e 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
2020-06-25 11:00:35 +00:00
@@ -1,5 +1,10 @@
package net.minecraft.server;
2016-02-29 23:09:49 +00:00
2020-06-25 11:00:35 +00:00
+import co.aikar.timings.Timing;
+import co.aikar.timings.Timings;
2016-02-29 23:09:49 +00:00
+import com.destroystokyo.paper.event.server.ServerExceptionEvent;
+import com.destroystokyo.paper.exception.ServerInternalException;
2019-04-26 01:24:00 +00:00
+import com.google.common.base.MoreObjects;
import com.google.common.collect.Lists;
2020-06-25 11:00:35 +00:00
import com.mojang.serialization.Codec;
2019-04-26 01:24:00 +00:00
import java.io.IOException;
2020-06-26 16:20:03 +00:00
@@ -720,8 +725,11 @@ public abstract class World implements GeneratorAccess, AutoCloseable {
2019-04-26 01:24:00 +00:00
gameprofilerfiller.exit();
} catch (Throwable throwable) {
2016-02-29 23:09:49 +00:00
// Paper start - Prevent tile entity and entity crashes
2016-02-29 01:15:51 +00:00
- System.err.println("TileEntity threw exception at " + tileentity.world.getWorld().getName() + ":" + tileentity.position.getX() + "," + tileentity.position.getY() + "," + tileentity.position.getZ());
+ String msg = "TileEntity threw exception at " + tileentity.world.getWorld().getName() + ":" + tileentity.position.getX() + "," + tileentity.position.getY() + "," + tileentity.position.getZ();
+ System.err.println(msg);
2019-04-26 01:24:00 +00:00
throwable.printStackTrace();
+ getServer().getPluginManager().callEvent(new ServerExceptionEvent(new ServerInternalException(msg, throwable)));
+ // Paper end
2016-02-29 01:15:51 +00:00
tilesThisCycle--;
2016-02-29 23:09:49 +00:00
this.tileEntityListTick.remove(tileTickPosition--);
2016-02-29 01:15:51 +00:00
continue;
2020-06-26 16:20:03 +00:00
@@ -792,8 +800,10 @@ public abstract class World implements GeneratorAccess, AutoCloseable {
2019-04-26 01:24:00 +00:00
consumer.accept(entity);
} catch (Throwable throwable) {
// Paper start - Prevent tile entity and entity crashes
2019-12-11 02:43:21 +00:00
- System.err.println("Entity threw exception at " + entity.world.getWorld().getName() + ":" + entity.locX() + "," + entity.locY() + "," + entity.locZ());
+ String msg = "Entity threw exception at " + entity.world.getWorld().getName() + ":" + entity.locX() + "," + entity.locY() + "," + entity.locZ();
2019-04-26 01:24:00 +00:00
+ System.err.println(msg);
throwable.printStackTrace();
+ getServer().getPluginManager().callEvent(new ServerExceptionEvent(new ServerInternalException(msg, throwable)));
entity.dead = true;
return;
// Paper end
diff --git a/src/main/java/net/minecraft/server/WorldPersistentData.java b/src/main/java/net/minecraft/server/WorldPersistentData.java
index 19e68a78310de787bca701bc2597c64e34a77d7c..a2a25cf6a43a1f59a80c997e2980f2bb8e6b3817 100644
--- a/src/main/java/net/minecraft/server/WorldPersistentData.java
+++ b/src/main/java/net/minecraft/server/WorldPersistentData.java
@@ -121,6 +121,7 @@ public class WorldPersistentData {
2019-04-26 01:24:00 +00:00
nbttagcompound = GameProfileSerializer.a(this.c, DataFixTypes.SAVED_DATA, nbttagcompound1, j, i);
} catch (Throwable throwable4) {
throwable = throwable4;
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(throwable); // Paper
throw throwable4;
} finally {
2019-04-26 01:24:00 +00:00
if (pushbackinputstream != null) {
2016-02-29 01:15:51 +00:00
diff --git a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
index ffe9cc1011226d604dc5499e7692e9a9a5132b72..343cdb06881fa8b0155b56d29c110bba489f9667 100644
2016-02-29 01:15:51 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
+++ b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
2019-04-26 01:24:00 +00:00
@@ -16,6 +16,9 @@ import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Consumer;
2016-02-29 23:09:49 +00:00
import java.util.logging.Level;
+import com.destroystokyo.paper.ServerSchedulerReportingWrapper;
+import com.destroystokyo.paper.event.server.ServerExceptionEvent;
+import com.destroystokyo.paper.exception.ServerSchedulerException;
import org.apache.commons.lang.Validate;
import org.bukkit.plugin.IllegalPluginAccessException;
import org.bukkit.plugin.Plugin;
@@ -419,6 +422,8 @@ public class CraftScheduler implements BukkitScheduler {
msg,
2016-02-29 01:15:51 +00:00
throwable);
}
2016-02-29 01:15:51 +00:00
+ task.getOwner().getServer().getPluginManager().callEvent(
+ new ServerExceptionEvent(new ServerSchedulerException(msg, throwable, task)));
// Paper end
2018-06-21 03:29:33 +00:00
} finally {
currentTask = null;
@@ -426,7 +431,7 @@ public class CraftScheduler implements BukkitScheduler {
2016-02-29 01:15:51 +00:00
parsePending();
} else {
debugTail = debugTail.setNext(new CraftAsyncDebugger(currentTick + RECENT_TICKS, task.getOwner(), task.getTaskClass()));
- executor.execute(task);
+ executor.execute(new ServerSchedulerReportingWrapper(task)); // Paper
// We don't need to parse pending
// (async tasks must live with race-conditions if they attempt to cancel between these few lines of code)
}