2019-06-14 02:27:40 +00:00
From 97c0bae11704c0340b9a20d26d06cd1bc286c7be Mon Sep 17 00:00:00 2001
2017-06-09 14:29:59 +00:00
From: kashike <kashike@vq.lc>
Date: Fri, 9 Jun 2017 07:24:24 -0700
Subject: [PATCH] Add configuration option to prevent player names from being
suggested
diff --git a/src/main/java/org/bukkit/Bukkit.java b/src/main/java/org/bukkit/Bukkit.java
2019-06-06 15:36:57 +00:00
index a0a8b5408..b5b77b2d8 100644
2017-06-09 14:29:59 +00:00
--- a/src/main/java/org/bukkit/Bukkit.java
+++ b/src/main/java/org/bukkit/Bukkit.java
2019-05-14 02:20:58 +00:00
@@ -1532,6 +1532,16 @@ public final class Bukkit {
2017-06-09 14:29:59 +00:00
public static boolean reloadCommandAliases() {
return server.reloadCommandAliases();
}
+
+ /**
+ * Checks if player names should be suggested when a command returns {@code null} as
+ * their tab completion result.
+ *
+ * @return true if player names should be suggested
+ */
+ public static boolean suggestPlayerNamesWhenNullTabCompletions() {
+ return server.suggestPlayerNamesWhenNullTabCompletions();
+ }
// Paper end
2019-03-20 00:28:15 +00:00
@NotNull
2017-06-09 14:29:59 +00:00
diff --git a/src/main/java/org/bukkit/Server.java b/src/main/java/org/bukkit/Server.java
2019-06-06 15:36:57 +00:00
index d20e044dd..103897fbe 100644
2017-06-09 14:29:59 +00:00
--- a/src/main/java/org/bukkit/Server.java
+++ b/src/main/java/org/bukkit/Server.java
2019-05-14 02:20:58 +00:00
@@ -1342,4 +1342,14 @@ public interface Server extends PluginMessageRecipient {
2017-06-09 14:29:59 +00:00
void reloadPermissions(); // Paper
boolean reloadCommandAliases(); // Paper
+
+ // Paper start - allow preventing player name suggestions by default
+ /**
+ * Checks if player names should be suggested when a command returns {@code null} as
+ * their tab completion result.
+ *
+ * @return true if player names should be suggested
+ */
+ boolean suggestPlayerNamesWhenNullTabCompletions();
+ // Paper end
}
diff --git a/src/main/java/org/bukkit/command/PluginCommand.java b/src/main/java/org/bukkit/command/PluginCommand.java
2019-06-06 15:36:57 +00:00
index 7f153000e..1e126487d 100644
2017-06-09 14:29:59 +00:00
--- a/src/main/java/org/bukkit/command/PluginCommand.java
+++ b/src/main/java/org/bukkit/command/PluginCommand.java
2019-05-06 02:58:04 +00:00
@@ -151,6 +151,7 @@ public final class PluginCommand extends Command implements PluginIdentifiableCo
2017-06-09 14:29:59 +00:00
}
if (completions == null) {
+ if (!sender.getServer().suggestPlayerNamesWhenNullTabCompletions()) return com.google.common.collect.ImmutableList.of(); // Paper - allow preventing player name suggestions by default
return super.tabComplete(sender, alias, args);
}
return completions;
--
2019-03-20 00:28:15 +00:00
2.21.0
2017-06-09 14:29:59 +00:00