core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0347-Don-t-check-ConvertSig...

33 lines
1.3 KiB
Diff
Raw Normal View History

Remove patch for MC-111480, fixed in 1.14 We were now starting entities at ID 2
2020-04-12 00:39:21 +00:00
From 5d8bd0865903c86671778b54e097386e96e13210 Mon Sep 17 00:00:00 2001
don't check convert signs boolean every sign save that lookup isn't "cheap", and synchronizes so cache it to a boolean instead
2019-03-02 20:29:09 +00:00
From: Aikar <aikar@aikar.co>
Date: Sat, 2 Mar 2019 11:11:29 -0500
Subject: [PATCH] Don't check ConvertSigns boolean every sign save
property lookups arent super cheap. they synchronize, validate
and check security managers.
diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 122289ff Add FaceAttachable interface to handle Grindstone facing in common with Switches a6db750e SPIGOT-5647: ZombieVillager entity should have getVillagerType() CraftBukkit Changes: bbe3d58e SPIGOT-5650: Lectern.setPage(int) causes a NullPointerException 3075579f Add FaceAttachable interface to handle Grindstone facing in common with Switches 95bd4238 SPIGOT-5647: ZombieVillager entity should have getVillagerType() 4d975ac3 SPIGOT-5617: setBlockData does not work when NotPlayEvent is called by redstone current
2020-04-02 21:07:06 +00:00
index a934020190..0e9a90b70f 100644
don't check convert signs boolean every sign save that lookup isn't "cheap", and synchronizes so cache it to a boolean instead
2019-03-02 20:29:09 +00:00
--- a/src/main/java/net/minecraft/server/TileEntitySign.java
+++ b/src/main/java/net/minecraft/server/TileEntitySign.java
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
@@ -11,6 +11,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
private final String[] g = new String[4];
private EnumColor color;
public java.util.UUID signEditor; // Paper
+ private static final boolean CONVERT_LEGACY_SIGNS = Boolean.getBoolean("convertLegacySigns"); // Paper
don't check convert signs boolean every sign save that lookup isn't "cheap", and synchronizes so cache it to a boolean instead
2019-03-02 20:29:09 +00:00
public TileEntitySign() {
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
super(TileEntityTypes.SIGN);
@@ -28,7 +29,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
don't check convert signs boolean every sign save that lookup isn't "cheap", and synchronizes so cache it to a boolean instead
2019-03-02 20:29:09 +00:00
}
// CraftBukkit start
- if (Boolean.getBoolean("convertLegacySigns")) {
+ if (CONVERT_LEGACY_SIGNS) { // Paper
nbttagcompound.setBoolean("Bukkit.isConverted", true);
}
// CraftBukkit end
--
Drop Ignore-Missing-Recipes-in-RecipeBook-to-avoid-data-e.patch This patch appears to be no longer relevant, and is seemingly a leading cause of datapack performance being horrific
2020-03-15 20:03:36 +00:00
2.25.1
don't check convert signs boolean every sign save that lookup isn't "cheap", and synchronizes so cache it to a boolean instead
2019-03-02 20:29:09 +00:00