core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0062-Remove-Metadata-on-rel...

32 lines
1.3 KiB
Diff
Raw Normal View History

Rebuild all patches using the new rebuild pattern
2020-05-06 09:48:49 +00:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
From: Aikar <aikar@aikar.co>
Date: Fri, 18 Mar 2016 13:50:14 -0400
Subject: [PATCH] Remove Metadata on reload
Metadata is not meant to persist reload as things break badly with non primitive types
This will remove metadata on reload so it does not crash everything if a plugin uses it.
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
Updated Upstream (Bukkit/CraftBukkit) (#3980) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 09f10fd9 SPIGOT-5950: Add PrepareSmithingEvent event CraftBukkit Changes: 7c03d257 SPIGOT-6011: End Gateways do not work on Non-Main End Worlds d492e363 SPIGOT-6015: Small Armor Stand doesn't drop items 5db13eea SPIGOT-5950: Add PrepareSmithingEvent event
2020-07-22 23:35:44 +00:00
index ed6832b13c4e59afb2e8e74f075c991f9f91de39..b98efc399fd6d8af53c3a2b74bbbdb97d9ea11e8 100644
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
[Auto] Updated Upstream (CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing CraftBukkit Changes: dc7c3c61f SPIGOT-5921: Improve setNoDamageTicks for Players 53849f57f SPIGOT-5922: Smithing recipes not registering
2020-07-02 01:27:09 +00:00
@@ -865,8 +865,18 @@ public final class CraftServer implements Server {
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
world.paperConfig.init(); // Paper
}
Clear plugin metadata only after onDisable() Fixes GH-776
2017-07-15 19:38:16 +00:00
+ Plugin[] pluginClone = pluginManager.getPlugins().clone(); // Paper
pluginManager.clearPlugins();
commandMap.clearCommands();
+
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
+ // Paper start
Clear plugin metadata only after onDisable() Fixes GH-776
2017-07-15 19:38:16 +00:00
+ for (Plugin plugin : pluginClone) {
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
+ entityMetadata.removeAll(plugin);
+ worldMetadata.removeAll(plugin);
+ playerMetadata.removeAll(plugin);
+ }
+ // Paper end
+
resetRecipes();
Clear plugin metadata only after onDisable() Fixes GH-776
2017-07-15 19:38:16 +00:00
reloadData();
org.spigotmc.SpigotConfig.registerCommands(); // Spigot