2018-10-05 03:18:46 +00:00
|
|
|
From d470ccd2730c7898a6036ed37307d897ae1c72de Mon Sep 17 00:00:00 2001
|
2017-01-07 21:08:16 +00:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Sat, 7 Jan 2017 16:06:44 -0500
|
|
|
|
Subject: [PATCH] Enforce Sync Chunk Unloads
|
|
|
|
|
|
|
|
Unloading Chunks async is extremely dangerous. This will force it to main
|
|
|
|
the same way we handle async chunk loads.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
2018-09-27 02:35:42 +00:00
|
|
|
index f83a28dfda..8aa3ffdde0 100644
|
2017-01-07 21:08:16 +00:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
2018-09-27 02:35:42 +00:00
|
|
|
@@ -230,6 +230,7 @@ public class CraftWorld implements World {
|
2017-01-07 21:08:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
private boolean unloadChunk0(int x, int z, boolean save) {
|
|
|
|
+ Boolean result = MCUtil.ensureMain("Unload Chunk", () -> { // Paper - Ensure never async
|
2018-08-26 18:11:49 +00:00
|
|
|
net.minecraft.server.Chunk chunk = world.getChunkProviderServer().getChunkAt(x, z, false, false);
|
2017-01-07 21:08:16 +00:00
|
|
|
if (chunk == null) {
|
|
|
|
return true;
|
2018-09-27 02:35:42 +00:00
|
|
|
@@ -237,6 +238,7 @@ public class CraftWorld implements World {
|
2017-01-07 21:08:16 +00:00
|
|
|
|
|
|
|
// If chunk had previously been queued to save, must do save to avoid loss of that data
|
|
|
|
return world.getChunkProviderServer().unloadChunk(chunk, chunk.mustSave || save);
|
|
|
|
+ }); return result != null ? result : false; // Paper - Ensure never async
|
|
|
|
}
|
|
|
|
|
|
|
|
public boolean regenerateChunk(int x, int z) {
|
|
|
|
--
|
2018-09-22 07:16:43 +00:00
|
|
|
2.19.0
|
2017-01-07 21:08:16 +00:00
|
|
|
|