2019-12-12 16:20:43 +00:00
From 5c3534a9d83d87e197cb35ab9b6bd5c6ba667e2d Mon Sep 17 00:00:00 2001
2019-05-21 01:37:47 +00:00
From: Shane Freeder <theboyetronic@gmail.com>
Date: Tue, 21 May 2019 02:34:04 +0100
2019-05-21 20:32:47 +00:00
Subject: [PATCH] improve CraftWorld#isChunkLoaded
2019-05-21 01:37:47 +00:00
2019-05-21 20:32:47 +00:00
getChunkAt will request the chunk using vanillas chunk loading system,
which while we're not going to load the chunk, does involve the server
waiting for the execution queue to get to our request; We can just query
the chunk status and get a response now, vs having to wait
2019-05-21 01:37:47 +00:00
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
2019-12-12 16:20:43 +00:00
index 12362d560..29c14c707 100644
2019-05-21 01:37:47 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
+++ b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
2019-12-12 16:20:43 +00:00
@@ -404,14 +404,13 @@ public class CraftWorld implements World {
2019-05-21 01:37:47 +00:00
@Override
public boolean isChunkLoaded(int x, int z) {
- net.minecraft.server.Chunk chunk = world.getChunkProvider().getChunkAt(x, z, false);
2019-05-26 01:56:30 +00:00
- return chunk != null;
2019-06-11 00:29:30 +00:00
+ return world.getChunkProvider().getChunkAtIfLoadedImmediately(x, z) != null; // Paper
2019-05-21 01:37:47 +00:00
}
@Override
2019-06-14 02:27:40 +00:00
public boolean isChunkGenerated(int x, int z) {
try {
2019-12-12 16:20:43 +00:00
- return isChunkLoaded(x, z) || world.getChunkProvider().playerChunkMap.read(new ChunkCoordIntPair(x, z)) != null;
+ return world.getChunkProvider().getChunkAtIfCachedImmediately(x, z) != null || world.getChunkProvider().playerChunkMap.read(new ChunkCoordIntPair(x, z)) != null; // Paper (TODO check if the first part can be removed)
2019-06-14 02:27:40 +00:00
} catch (IOException ex) {
throw new RuntimeException(ex);
}
2019-05-21 01:37:47 +00:00
--
2019-12-12 16:20:43 +00:00
2.24.1
2019-05-21 01:37:47 +00:00