2020-05-06 09:48:49 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2019-02-28 05:47:57 +00:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Thu, 28 Feb 2019 00:15:28 -0500
|
|
|
|
Subject: [PATCH] Fix sign edit memory leak
|
|
|
|
|
|
|
|
when a player edits a sign, a reference to their Entity is never cleand up.
|
|
|
|
|
2021-03-16 07:19:45 +00:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/network/PlayerConnection.java b/src/main/java/net/minecraft/server/network/PlayerConnection.java
|
|
|
|
index a2413a4e1d16b856df9f74e42eb141f72b0893c6..593609ff38b01ae35e17dd65bf101e38d080dc3a 100644
|
|
|
|
--- a/src/main/java/net/minecraft/server/network/PlayerConnection.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/network/PlayerConnection.java
|
|
|
|
@@ -2838,7 +2838,7 @@ public class PlayerConnection implements PacketListenerPlayIn {
|
2019-02-28 05:47:57 +00:00
|
|
|
|
|
|
|
TileEntitySign tileentitysign = (TileEntitySign) tileentity;
|
|
|
|
|
2019-05-27 23:01:45 +00:00
|
|
|
- if (!tileentitysign.d() || tileentitysign.f() != this.player) {
|
|
|
|
+ if (!tileentitysign.d() || tileentitysign.signEditor == null || !tileentitysign.signEditor.equals(this.player.getUniqueID())) {
|
2020-06-25 14:09:55 +00:00
|
|
|
PlayerConnection.LOGGER.warn("Player {} just tried to change non-editable sign", this.player.getDisplayName().getString());
|
2019-02-28 05:47:57 +00:00
|
|
|
this.sendPacket(tileentity.getUpdatePacket()); // CraftBukkit
|
|
|
|
return;
|
2021-03-16 07:19:45 +00:00
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/block/entity/TileEntitySign.java b/src/main/java/net/minecraft/world/level/block/entity/TileEntitySign.java
|
|
|
|
index ec550aaa4e7943af4ecdd2275f1f32c21edf770a..6d0fe58d7e574ce5189e1f7a8485060d60b466d9 100644
|
|
|
|
--- a/src/main/java/net/minecraft/world/level/block/entity/TileEntitySign.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/level/block/entity/TileEntitySign.java
|
|
|
|
@@ -30,6 +30,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
|
2020-02-11 04:35:46 +00:00
|
|
|
private EntityHuman c;
|
2020-08-25 02:22:08 +00:00
|
|
|
private final FormattedString[] g;
|
2020-02-11 04:35:46 +00:00
|
|
|
private EnumColor color;
|
|
|
|
+ public java.util.UUID signEditor; // Paper
|
2019-02-28 05:47:57 +00:00
|
|
|
|
|
|
|
public TileEntitySign() {
|
2020-02-11 04:35:46 +00:00
|
|
|
super(TileEntityTypes.SIGN);
|
2021-03-16 07:19:45 +00:00
|
|
|
@@ -131,7 +132,10 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
|
2019-02-28 05:47:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
public void a(EntityHuman entityhuman) {
|
2019-12-12 16:20:43 +00:00
|
|
|
- this.c = entityhuman;
|
2019-02-28 05:47:57 +00:00
|
|
|
+ // Paper start
|
2019-12-12 16:20:43 +00:00
|
|
|
+ //this.c = entityhuman;
|
2019-02-28 05:47:57 +00:00
|
|
|
+ signEditor = entityhuman != null ? entityhuman.getUniqueID() : null;
|
|
|
|
+ // Paper end
|
|
|
|
}
|
|
|
|
|
2019-05-27 23:01:45 +00:00
|
|
|
public EntityHuman f() {
|