2019-07-16 22:09:32 +00:00
From 5af5ec5c5b6a59f8b838c9d126e7945edaa383e6 Mon Sep 17 00:00:00 2001
2016-01-13 05:00:58 +00:00
From: Aikar <aikar@aikar.co>
2016-02-29 23:09:49 +00:00
Date: Thu, 3 Mar 2016 01:17:12 -0600
2016-01-13 05:00:58 +00:00
Subject: [PATCH] Ensure commands are not ran async
Plugins calling Player.chat("/foo") or Server.dispatchCommand() could
trigger the server to execute a command while on another thread.
These commands would then process EXPECTING to be on the main thread, leaving to
very hard to trace concurrency issues.
This change will synchronize the command execution back to the main thread, causing a
big slowdown in execution but throwing an exception at same time to raise awareness
that it is happening so that plugin authors can fix their code to stop executing commands async.
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
2019-07-16 22:09:32 +00:00
index d6550af41..58e7cede6 100644
2016-01-13 05:00:58 +00:00
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
2019-07-16 22:09:32 +00:00
@@ -1588,6 +1588,29 @@ public class PlayerConnection implements PacketListenerPlayIn {
2016-01-13 05:00:58 +00:00
}
if (!async && s.startsWith("/")) {
2016-02-29 23:09:49 +00:00
+ // Paper Start
2018-02-15 05:34:58 +00:00
+ if (!org.spigotmc.AsyncCatcher.shuttingDown && !org.bukkit.Bukkit.isPrimaryThread()) {
2016-01-13 05:00:58 +00:00
+ final String fCommandLine = s;
+ MinecraftServer.LOGGER.log(org.apache.logging.log4j.Level.ERROR, "Command Dispatched Async: " + fCommandLine);
+ MinecraftServer.LOGGER.log(org.apache.logging.log4j.Level.ERROR, "Please notify author of plugin causing this execution to fix this bug! see: http://bit.ly/1oSiM6C", new Throwable());
+ Waitable wait = new Waitable() {
+ @Override
+ protected Object evaluate() {
+ chat(fCommandLine, false);
+ return null;
+ }
+ };
+ minecraftServer.processQueue.add(wait);
+ try {
+ wait.get();
+ return;
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt(); // This is proper habit for java. If we aren't handling it, pass it on!
+ } catch (Exception e) {
+ throw new RuntimeException("Exception processing chat command", e.getCause());
+ }
+ }
2016-02-29 23:09:49 +00:00
+ // Paper End
2016-01-13 05:00:58 +00:00
this.handleCommand(s);
2019-04-25 06:53:51 +00:00
} else if (this.player.getChatFlags() == EnumChatVisibility.SYSTEM) {
2016-01-13 05:00:58 +00:00
// Do nothing, this is coming from a plugin
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
2019-07-16 22:09:32 +00:00
index cbee3453c..905fc64e5 100644
2016-01-13 05:00:58 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
2019-07-05 02:13:38 +00:00
@@ -707,6 +707,29 @@ public final class CraftServer implements Server {
2016-01-13 05:00:58 +00:00
Validate.notNull(commandLine, "CommandLine cannot be null");
2018-07-18 04:52:33 +00:00
org.spigotmc.AsyncCatcher.catchOp( "command dispatch" ); // Spigot
2016-01-13 05:00:58 +00:00
2016-02-29 23:09:49 +00:00
+ // Paper Start
2018-02-15 05:34:58 +00:00
+ if (!org.spigotmc.AsyncCatcher.shuttingDown && !Bukkit.isPrimaryThread()) {
2016-01-13 05:00:58 +00:00
+ final CommandSender fSender = sender;
+ final String fCommandLine = commandLine;
+ Bukkit.getLogger().log(Level.SEVERE, "Command Dispatched Async: " + commandLine);
+ Bukkit.getLogger().log(Level.SEVERE, "Please notify author of plugin causing this execution to fix this bug! see: http://bit.ly/1oSiM6C", new Throwable());
+ org.bukkit.craftbukkit.util.Waitable<Boolean> wait = new org.bukkit.craftbukkit.util.Waitable<Boolean>() {
+ @Override
+ protected Boolean evaluate() {
+ return dispatchCommand(fSender, fCommandLine);
+ }
+ };
+ net.minecraft.server.MinecraftServer.getServer().processQueue.add(wait);
+ try {
+ return wait.get();
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt(); // This is proper habit for java. If we aren't handling it, pass it on!
+ } catch (Exception e) {
+ throw new RuntimeException("Exception processing dispatch command", e.getCause());
+ }
+ }
2016-02-29 23:09:49 +00:00
+ // Paper End
2016-01-13 05:00:58 +00:00
+
if (commandMap.dispatch(sender, commandLine)) {
return true;
}
2018-02-15 05:34:58 +00:00
diff --git a/src/main/java/org/bukkit/craftbukkit/util/ServerShutdownThread.java b/src/main/java/org/bukkit/craftbukkit/util/ServerShutdownThread.java
2019-07-16 22:09:32 +00:00
index ddef523ea..70f8d4299 100644
2018-02-15 05:34:58 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/util/ServerShutdownThread.java
+++ b/src/main/java/org/bukkit/craftbukkit/util/ServerShutdownThread.java
2019-04-25 06:53:51 +00:00
@@ -13,6 +13,7 @@ public class ServerShutdownThread extends Thread {
2018-02-15 05:34:58 +00:00
public void run() {
try {
org.spigotmc.AsyncCatcher.enabled = false; // Spigot
+ org.spigotmc.AsyncCatcher.shuttingDown = true; // Paper
2019-04-25 06:53:51 +00:00
server.close();
} finally {
try {
2018-02-15 05:34:58 +00:00
diff --git a/src/main/java/org/spigotmc/AsyncCatcher.java b/src/main/java/org/spigotmc/AsyncCatcher.java
2019-07-16 22:09:32 +00:00
index aeed76972..9f7d2ef93 100644
2018-02-15 05:34:58 +00:00
--- a/src/main/java/org/spigotmc/AsyncCatcher.java
+++ b/src/main/java/org/spigotmc/AsyncCatcher.java
@@ -6,6 +6,7 @@ public class AsyncCatcher
{
public static boolean enabled = true;
+ public static boolean shuttingDown = false; // Paper
public static void catchOp(String reason)
{
diff --git a/src/main/java/org/spigotmc/RestartCommand.java b/src/main/java/org/spigotmc/RestartCommand.java
2019-07-16 22:09:32 +00:00
index e7b953ca3..ccea803f5 100644
2018-02-15 05:34:58 +00:00
--- a/src/main/java/org/spigotmc/RestartCommand.java
+++ b/src/main/java/org/spigotmc/RestartCommand.java
@@ -43,6 +43,7 @@ public class RestartCommand extends Command
2019-01-01 03:15:55 +00:00
private static void restart(final String restartScript)
2018-02-15 05:34:58 +00:00
{
AsyncCatcher.enabled = false; // Disable async catcher incase it interferes with us
+ org.spigotmc.AsyncCatcher.shuttingDown = true; // Paper
try
{
2019-01-01 03:15:55 +00:00
String[] split = restartScript.split( " " );
2016-01-13 05:00:58 +00:00
--
2019-07-02 04:51:06 +00:00
2.22.0
2016-01-13 05:00:58 +00:00