core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0333-Fix-sign-edit-memory-l...

45 lines
2.2 KiB
Diff
Raw Normal View History

Rebuild all patches using the new rebuild pattern
2020-05-06 09:48:49 +00:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
From: Aikar <aikar@aikar.co>
Date: Thu, 28 Feb 2019 00:15:28 -0500
Subject: [PATCH] Fix sign edit memory leak
when a player edits a sign, a reference to their Entity is never cleand up.
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: f009c3dd SPIGOT-5810, SPIGOT-5835: 'Better' handling of Player.isOnGround e677c370 Update ECJ version 5058a35d SPIGOT-5860: Item.setItemStack should be NotNull CraftBukkit Changes: d77f4d9b SPIGOT-5810, SPIGOT-5835: 'Better' handling of Player.isOnGround 53c95627 SPIGOT-5865: Piglin does not trigger EntityPickupItemEvent 2ab04d24 Update ECJ version 7884e079 SPIGOT-5868: Blocks do not tick in custom nether / end 2a848286 SPIGOT-5863: Don't check colour in scoreboard length validation f2cbce30 SPIGOT-5866: Beehive unknown TargetReason Spigot Changes: ad703da0 SPIGOT-5870: /plugins "website" field shows "version" 1a27cfd8 #98: Improve output of /plugins command using text components 732d5bab Disable checkstyle in Spigot blocks 0199a9a6 #97: Add Memory Usage to Ticks Per Second Command. 33ea98fc SPIGOT-5858: NPE: Joining the server with an invalid dimension
2020-06-28 01:54:05 +00:00
index b7612fb450063e48a81ca95e7dedebb7f6e7789c..22a185c298f4738669708c8c6ef8ef9aeff0acc1 100644
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: f009c3dd SPIGOT-5810, SPIGOT-5835: 'Better' handling of Player.isOnGround e677c370 Update ECJ version 5058a35d SPIGOT-5860: Item.setItemStack should be NotNull CraftBukkit Changes: d77f4d9b SPIGOT-5810, SPIGOT-5835: 'Better' handling of Player.isOnGround 53c95627 SPIGOT-5865: Piglin does not trigger EntityPickupItemEvent 2ab04d24 Update ECJ version 7884e079 SPIGOT-5868: Blocks do not tick in custom nether / end 2a848286 SPIGOT-5863: Don't check colour in scoreboard length validation f2cbce30 SPIGOT-5866: Beehive unknown TargetReason Spigot Changes: ad703da0 SPIGOT-5870: /plugins "website" field shows "version" 1a27cfd8 #98: Improve output of /plugins command using text components 732d5bab Disable checkstyle in Spigot blocks 0199a9a6 #97: Add Memory Usage to Ticks Per Second Command. 33ea98fc SPIGOT-5858: NPE: Joining the server with an invalid dimension
2020-06-28 01:54:05 +00:00
@@ -2587,7 +2587,7 @@ public class PlayerConnection implements PacketListenerPlayIn {
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
TileEntitySign tileentitysign = (TileEntitySign) tileentity;
Update to 1.14.2
2019-05-27 23:01:45 +00:00
- if (!tileentitysign.d() || tileentitysign.f() != this.player) {
+ if (!tileentitysign.d() || tileentitysign.signEditor == null || !tileentitysign.signEditor.equals(this.player.getUniqueID())) {
even even even more work
2020-06-25 14:09:55 +00:00
PlayerConnection.LOGGER.warn("Player {} just tried to change non-editable sign", this.player.getDisplayName().getString());
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
this.sendPacket(tileentity.getUpdatePacket()); // CraftBukkit
return;
diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java
even even even more work
2020-06-25 14:09:55 +00:00
index 8e77c662f7d970d8ff86f6c5b9bccc598442594d..2746cb4d4950b303f4d6b4822223d26b51ebe5a4 100644
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
--- a/src/main/java/net/minecraft/server/TileEntitySign.java
+++ b/src/main/java/net/minecraft/server/TileEntitySign.java
even even even more work
2020-06-25 14:09:55 +00:00
@@ -11,6 +11,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
private EntityHuman c;
even even even more work
2020-06-25 14:09:55 +00:00
private final IChatFormatted[] g;
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
private EnumColor color;
+ public java.util.UUID signEditor; // Paper
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
public TileEntitySign() {
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
super(TileEntityTypes.SIGN);
even even even more work
2020-06-25 14:09:55 +00:00
@@ -112,7 +113,10 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
}
public void a(EntityHuman entityhuman) {
Houston, we got a patch (#2731) * Houston, we got a patch * is this the end of the beginning or the beginning of the end
2019-12-12 16:20:43 +00:00
- this.c = entityhuman;
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
+ // Paper start
Houston, we got a patch (#2731) * Houston, we got a patch * is this the end of the beginning or the beginning of the end
2019-12-12 16:20:43 +00:00
+ //this.c = entityhuman;
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
+ signEditor = entityhuman != null ? entityhuman.getUniqueID() : null;
+ // Paper end
}
Update to 1.14.2
2019-05-27 23:01:45 +00:00
public EntityHuman f() {