2019-05-27 06:14:14 +00:00
|
|
|
From 5cf57792306a23fa4b0472b61bfe4715d96a3b6b Mon Sep 17 00:00:00 2001
|
2019-02-26 01:40:23 +00:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Wed, 6 Feb 2019 00:20:33 -0500
|
|
|
|
Subject: [PATCH] BlockDestroyEvent
|
|
|
|
|
|
|
|
Adds an event for when the server is going to destroy a current block,
|
|
|
|
potentially causing it to drop. This event can be cancelled to avoid
|
|
|
|
the block destruction, such as preventing signs from popping when
|
|
|
|
floating in the air.
|
|
|
|
|
|
|
|
This can replace many uses of BlockPhysicsEvent
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
2019-05-27 06:14:14 +00:00
|
|
|
index 3425f034c8..4280fdf807 100644
|
2019-02-26 01:40:23 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
2019-05-27 06:14:14 +00:00
|
|
|
@@ -486,8 +486,20 @@ public abstract class World implements IIBlockAccess, GeneratorAccess, AutoClose
|
2019-02-26 01:40:23 +00:00
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
Fluid fluid = this.getFluid(blockposition);
|
|
|
|
+ // Paper start - while the above setAir method is named same and looks very similar
|
|
|
|
+ // they are NOT used with same intent and the above should not fire this event. The above method is more of a BlockSetToAirEvent,
|
|
|
|
+ // it doesn't imply destruction of a block that plays a sound effect / drops an item.
|
|
|
|
+ boolean playEffect = true;
|
|
|
|
+ if (com.destroystokyo.paper.event.block.BlockDestroyEvent.getHandlerList().getRegisteredListeners().length > 0) {
|
2019-05-05 23:24:37 +00:00
|
|
|
+ com.destroystokyo.paper.event.block.BlockDestroyEvent event = new com.destroystokyo.paper.event.block.BlockDestroyEvent(MCUtil.toBukkitBlock(this, blockposition), fluid.getBlockData().createCraftBlockData(), flag);
|
2019-02-26 01:40:23 +00:00
|
|
|
+ if (!event.callEvent()) {
|
|
|
|
+ return false;
|
|
|
|
+ }
|
|
|
|
+ playEffect = event.playEffect();
|
|
|
|
+ }
|
|
|
|
+ // Paper end
|
|
|
|
|
|
|
|
- this.triggerEffect(2001, blockposition, Block.getCombinedId(iblockdata));
|
|
|
|
+ if (playEffect) this.triggerEffect(2001, blockposition, Block.getCombinedId(iblockdata)); // Paper
|
|
|
|
if (flag) {
|
2019-05-05 17:19:34 +00:00
|
|
|
TileEntity tileentity = iblockdata.getBlock().isTileEntity() ? this.getTileEntity(blockposition) : null;
|
|
|
|
|
2019-02-26 01:40:23 +00:00
|
|
|
--
|
2019-03-20 00:28:15 +00:00
|
|
|
2.21.0
|
2019-02-26 01:40:23 +00:00
|
|
|
|