testserver/Spigot-Server-Patches/0343-Fix-sign-edit-memory-l...

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Thu, 28 Feb 2019 00:15:28 -0500
Subject: [PATCH] Fix sign edit memory leak

when a player edits a sign, a reference to their Entity is never cleand up.

diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
index 81d40e1dbc6c03033612e04a20cd18e0aa304d2e..75933d494737b71904b1a49646c17f84380ac267 100644
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
@@ -2547,7 +2547,7 @@ public class PlayerConnection implements PacketListenerPlayIn {
 
             TileEntitySign tileentitysign = (TileEntitySign) tileentity;
 
-            if (!tileentitysign.d() || tileentitysign.f() != this.player) {
+            if (!tileentitysign.d() || tileentitysign.signEditor == null || !tileentitysign.signEditor.equals(this.player.getUniqueID())) {
                 this.minecraftServer.warning("Player " + this.player.getDisplayName().getString() + " just tried to change non-editable sign");
                 this.sendPacket(tileentity.getUpdatePacket()); // CraftBukkit
                 return;
diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java
index 03f6ddf0003f0ef44ede31cf7a3491580ff0b5de..a934020190da937adaf2a0599259f85d3cbda269 100644
--- a/src/main/java/net/minecraft/server/TileEntitySign.java
+++ b/src/main/java/net/minecraft/server/TileEntitySign.java
@@ -10,6 +10,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
     private EntityHuman c;
     private final String[] g = new String[4];
     private EnumColor color;
+    public java.util.UUID signEditor; // Paper
 
     public TileEntitySign() {
         super(TileEntityTypes.SIGN);
@@ -108,7 +109,10 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
     }
 
     public void a(EntityHuman entityhuman) {
-        this.c = entityhuman;
+        // Paper start
+        //this.c = entityhuman;
+        signEditor = entityhuman != null ? entityhuman.getUniqueID() : null;
+        // Paper end
     }
 
     public EntityHuman f() {
Rebuild all patches using the new rebuild pattern 2020-05-06 09:48:49 +00:00			`From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`From: Aikar <aikar@aikar.co>`
			`Date: Thu, 28 Feb 2019 00:15:28 -0500`
			`Subject: [PATCH] Fix sign edit memory leak`

			`when a player edits a sign, a reference to their Entity is never cleand up.`

			`diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java`
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing My recent work on serialization is now in CraftBukkit so was able to drop the patch and Paper is now consistent with upstream. Bukkit Changes: e2699636 Move API notes to more obvious location CraftBukkit Changes: 1b2830a3 SPIGOT-4441: Fix serializing Components to and from Legacy 2020-06-02 03:15:47 +00:00			`index 81d40e1dbc6c03033612e04a20cd18e0aa304d2e..75933d494737b71904b1a49646c17f84380ac267 100644`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`--- a/src/main/java/net/minecraft/server/PlayerConnection.java`
			`+++ b/src/main/java/net/minecraft/server/PlayerConnection.java`
Handle CraftPlayer#setSpectatorTarget better Use a proper teleport for teleporting to entities in different worlds. Validate that the target entity is valid and deny spectate requests from frozen players. Also, make sure the entity is spawned to the client before sending the camera packet. If the entity isn't spawned clientside when it receives the camera packet, then the client will not spectate the target entity. 2020-05-14 23:05:00 +00:00			`@@ -2547,7 +2547,7 @@ public class PlayerConnection implements PacketListenerPlayIn {`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00
			`TileEntitySign tileentitysign = (TileEntitySign) tileentity;`

Update to 1.14.2 2019-05-27 23:01:45 +00:00			`- if (!tileentitysign.d() \|\| tileentitysign.f() != this.player) {`
			`+ if (!tileentitysign.d() \|\| tileentitysign.signEditor == null \|\| !tileentitysign.signEditor.equals(this.player.getUniqueID())) {`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`this.minecraftServer.warning("Player " + this.player.getDisplayName().getString() + " just tried to change non-editable sign");`
			`this.sendPacket(tileentity.getUpdatePacket()); // CraftBukkit`
			`return;`
			`diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java`
Rebuild all patches using the new rebuild pattern 2020-05-06 09:48:49 +00:00			`index 03f6ddf0003f0ef44ede31cf7a3491580ff0b5de..a934020190da937adaf2a0599259f85d3cbda269 100644`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`--- a/src/main/java/net/minecraft/server/TileEntitySign.java`
			`+++ b/src/main/java/net/minecraft/server/TileEntitySign.java`
Stop stripping private use block Unicode from signs Fixes GH-2943 2020-02-11 04:35:46 +00:00			`@@ -10,6 +10,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //`
			`private EntityHuman c;`
			`private final String[] g = new String[4];`
			`private EnumColor color;`
			`+ public java.util.UUID signEditor; // Paper`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00
			`public TileEntitySign() {`
Stop stripping private use block Unicode from signs Fixes GH-2943 2020-02-11 04:35:46 +00:00			`super(TileEntityTypes.SIGN);`
			`@@ -108,7 +109,10 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`}`

			`public void a(EntityHuman entityhuman) {`
Houston, we got a patch (#2731) * Houston, we got a patch * is this the end of the beginning or the beginning of the end 2019-12-12 16:20:43 +00:00			`- this.c = entityhuman;`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`+ // Paper start`
Houston, we got a patch (#2731) * Houston, we got a patch * is this the end of the beginning or the beginning of the end 2019-12-12 16:20:43 +00:00			`+ //this.c = entityhuman;`
Fix a sign memory leak 2019-02-28 05:47:57 +00:00			`+ signEditor = entityhuman != null ? entityhuman.getUniqueID() : null;`
			`+ // Paper end`
			`}`

Update to 1.14.2 2019-05-27 23:01:45 +00:00			`public EntityHuman f() {`