core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0063-Remove-Metadata-on-rel...

35 lines
1.3 KiB
Diff
Raw Normal View History

Move version command update checking to the implementation This makes it easier for downstream projects (forks) to replace the version fetching system with their own. It is as simple as implementing an interface and overriding the default implementation of org.bukkit.UnsafeValues#getVersionFetcher() It also makes it easier for us to organize things like the version history feature. Lastly I have updated the paper implementation to check against the site API rather than against jenkins.
2019-05-27 09:13:41 +00:00
From dc8aa52ba9b344ae5b6514c3e684b5f32c1bceb4 Mon Sep 17 00:00:00 2001
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
From: Aikar <aikar@aikar.co>
Date: Fri, 18 Mar 2016 13:50:14 -0400
Subject: [PATCH] Remove Metadata on reload
Metadata is not meant to persist reload as things break badly with non primitive types
This will remove metadata on reload so it does not crash everything if a plugin uses it.
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
Move version command update checking to the implementation This makes it easier for downstream projects (forks) to replace the version fetching system with their own. It is as simple as implementing an interface and overriding the default implementation of org.bukkit.UnsafeValues#getVersionFetcher() It also makes it easier for us to organize things like the version history feature. Lastly I have updated the paper implementation to check against the site API rather than against jenkins.
2019-05-27 09:13:41 +00:00
index dbc58436c..954eb497b 100644
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
More work for 1.14
2019-04-26 01:24:00 +00:00
@@ -795,8 +795,18 @@ public final class CraftServer implements Server {
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
world.paperConfig.init(); // Paper
}
Clear plugin metadata only after onDisable() Fixes GH-776
2017-07-15 19:38:16 +00:00
+ Plugin[] pluginClone = pluginManager.getPlugins().clone(); // Paper
pluginManager.clearPlugins();
commandMap.clearCommands();
+
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
+ // Paper start
Clear plugin metadata only after onDisable() Fixes GH-776
2017-07-15 19:38:16 +00:00
+ for (Plugin plugin : pluginClone) {
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
+ entityMetadata.removeAll(plugin);
+ worldMetadata.removeAll(plugin);
+ playerMetadata.removeAll(plugin);
+ }
+ // Paper end
+
resetRecipes();
Clear plugin metadata only after onDisable() Fixes GH-776
2017-07-15 19:38:16 +00:00
reloadData();
org.spigotmc.SpigotConfig.registerCommands(); // Spigot
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00
--
Initial work on 1.14 pre-5
2019-04-23 04:47:07 +00:00
2.21.0
Remove, not invalidate, Metadata on reload Objects loaded over different class loaders are not the same. Nasty dragons lie here. Also clean up the previous patch to no longer butcher imports.
2016-03-29 02:43:05 +00:00