2016-03-03 09:46:26 +00:00
|
|
|
From 983be83bdbd9f5a39c09dd55eee555a6438dc434 Mon Sep 17 00:00:00 2001
|
2015-06-16 12:55:15 +00:00
|
|
|
From: Byteflux <byte@byteflux.net>
|
2016-02-29 23:09:49 +00:00
|
|
|
Date: Wed, 2 Mar 2016 11:59:48 -0600
|
2015-06-16 12:55:15 +00:00
|
|
|
Subject: [PATCH] Optimize explosions
|
|
|
|
|
|
|
|
The process of determining an entity's exposure from explosions can be
|
|
|
|
expensive when there are hundreds or more entities in range.
|
|
|
|
|
|
|
|
This patch adds a per-tick cache that is used for storing and retrieving
|
|
|
|
an entity's exposure during an explosion.
|
|
|
|
|
2016-02-29 23:09:49 +00:00
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2016-03-03 09:46:26 +00:00
|
|
|
index 74d22f7..d022513 100644
|
2016-02-29 23:09:49 +00:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
@@ -193,4 +193,10 @@ public class PaperWorldConfig {
|
|
|
|
generateVillage = getBoolean("generator-settings.village", true);
|
|
|
|
generateFlatBedrock = getBoolean("generator-settings.flat-bedrock", false);
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public boolean optimizeExplosions;
|
|
|
|
+ private void optimizeExplosions() {
|
|
|
|
+ optimizeExplosions = getBoolean("optimize-explosions", false);
|
|
|
|
+ log("Optimize explosions: " + optimizeExplosions);
|
|
|
|
+ }
|
|
|
|
}
|
2015-06-16 12:55:15 +00:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/Explosion.java b/src/main/java/net/minecraft/server/Explosion.java
|
2016-02-29 23:09:49 +00:00
|
|
|
index 87e123c..afe402e 100644
|
2015-06-16 12:55:15 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/Explosion.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/Explosion.java
|
|
|
|
@@ -129,7 +129,7 @@ public class Explosion {
|
|
|
|
d8 /= d11;
|
|
|
|
d9 /= d11;
|
|
|
|
d10 /= d11;
|
|
|
|
- double d12 = (double) this.world.a(vec3d, entity.getBoundingBox());
|
2016-02-29 23:09:49 +00:00
|
|
|
+ double d12 = this.getBlockDensity(vec3d, entity.getBoundingBox()); // Paper - Optimize explosions
|
2015-06-16 12:55:15 +00:00
|
|
|
double d13 = (1.0D - d7) * d12;
|
|
|
|
|
2016-02-29 23:09:49 +00:00
|
|
|
// CraftBukkit start
|
|
|
|
@@ -296,4 +296,85 @@ public class Explosion {
|
2015-06-16 12:55:15 +00:00
|
|
|
public List<BlockPosition> getBlocks() {
|
|
|
|
return this.blocks;
|
|
|
|
}
|
|
|
|
+
|
2016-02-29 23:09:49 +00:00
|
|
|
+ // Paper start - Optimize explosions
|
2015-06-16 12:55:15 +00:00
|
|
|
+ private float getBlockDensity(Vec3D vec3d, AxisAlignedBB aabb) {
|
2016-02-29 23:09:49 +00:00
|
|
|
+ if (!this.world.paperConfig.optimizeExplosions) {
|
2015-06-16 12:55:15 +00:00
|
|
|
+ return this.world.a(vec3d, aabb);
|
|
|
|
+ }
|
|
|
|
+ CacheKey key = new CacheKey(this, aabb);
|
|
|
|
+ Float blockDensity = this.world.explosionDensityCache.get(key);
|
|
|
|
+ if (blockDensity == null) {
|
|
|
|
+ blockDensity = this.world.a(vec3d, aabb);
|
|
|
|
+ this.world.explosionDensityCache.put(key, blockDensity);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ return blockDensity;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ static class CacheKey {
|
|
|
|
+ private final World world;
|
|
|
|
+ private final double posX, posY, posZ;
|
|
|
|
+ private final double minX, minY, minZ;
|
|
|
|
+ private final double maxX, maxY, maxZ;
|
|
|
|
+
|
|
|
|
+ public CacheKey(Explosion explosion, AxisAlignedBB aabb) {
|
|
|
|
+ this.world = explosion.world;
|
|
|
|
+ this.posX = explosion.posX;
|
|
|
|
+ this.posY = explosion.posY;
|
|
|
|
+ this.posZ = explosion.posZ;
|
|
|
|
+ this.minX = aabb.a;
|
|
|
|
+ this.minY = aabb.b;
|
|
|
|
+ this.minZ = aabb.c;
|
|
|
|
+ this.maxX = aabb.d;
|
|
|
|
+ this.maxY = aabb.e;
|
|
|
|
+ this.maxZ = aabb.f;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public boolean equals(Object o) {
|
|
|
|
+ if (this == o) return true;
|
|
|
|
+ if (o == null || getClass() != o.getClass()) return false;
|
|
|
|
+
|
|
|
|
+ CacheKey cacheKey = (CacheKey) o;
|
|
|
|
+
|
|
|
|
+ if (Double.compare(cacheKey.posX, posX) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.posY, posY) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.posZ, posZ) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.minX, minX) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.minY, minY) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.minZ, minZ) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.maxX, maxX) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.maxY, maxY) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.maxZ, maxZ) != 0) return false;
|
|
|
|
+ return world.equals(cacheKey.world);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public int hashCode() {
|
|
|
|
+ int result;
|
|
|
|
+ long temp;
|
|
|
|
+ result = world.hashCode();
|
|
|
|
+ temp = Double.doubleToLongBits(posX);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(posY);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(posZ);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(minX);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(minY);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(minZ);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(maxX);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(maxY);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(maxZ);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ return result;
|
|
|
|
+ }
|
|
|
|
+ }
|
2016-02-29 23:09:49 +00:00
|
|
|
+ // Paper end
|
2015-06-16 12:55:15 +00:00
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2016-03-03 09:46:26 +00:00
|
|
|
index db425fb..733f8e7 100644
|
2015-06-16 12:55:15 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2016-03-03 09:46:26 +00:00
|
|
|
@@ -863,6 +863,7 @@ public abstract class MinecraftServer implements Runnable, ICommandListener, IAs
|
2015-06-16 12:55:15 +00:00
|
|
|
worldserver.timings.tracker.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.b();
|
|
|
|
this.methodProfiler.b();
|
2016-02-29 23:09:49 +00:00
|
|
|
+ worldserver.explosionDensityCache.clear(); // Paper - Optimize explosions
|
2015-06-16 12:55:15 +00:00
|
|
|
// } // CraftBukkit
|
|
|
|
|
|
|
|
// this.i[i][this.ticks % 100] = System.nanoTime() - j; // CraftBukkit
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
2016-03-03 09:46:26 +00:00
|
|
|
index bbdfb3b..ee4642f 100644
|
2015-06-16 12:55:15 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
2016-02-29 23:09:49 +00:00
|
|
|
@@ -32,6 +32,7 @@ import org.bukkit.generator.ChunkGenerator;
|
|
|
|
// Paper start
|
|
|
|
import java.util.concurrent.ExecutorService;
|
|
|
|
import java.util.concurrent.Executors;
|
|
|
|
+import java.util.HashMap;
|
|
|
|
import com.google.common.util.concurrent.ThreadFactoryBuilder;
|
|
|
|
// Paper end
|
|
|
|
|
|
|
|
@@ -141,6 +142,7 @@ public abstract class World implements IBlockAccess {
|
2015-09-13 04:29:23 +00:00
|
|
|
private org.spigotmc.TickLimiter tileLimiter;
|
2015-06-16 12:55:15 +00:00
|
|
|
private int tileTickPosition;
|
2016-02-29 23:09:49 +00:00
|
|
|
public ExecutorService lightingExecutor = Executors.newSingleThreadExecutor(new ThreadFactoryBuilder().setNameFormat("Paper - Lighting Thread").build()); // Paper - Asynchronous lighting updates
|
|
|
|
+ public final Map<Explosion.CacheKey, Float> explosionDensityCache = new HashMap<Explosion.CacheKey, Float>(); // Paper - Optimize explosions
|
2015-06-16 12:55:15 +00:00
|
|
|
|
2016-02-29 23:09:49 +00:00
|
|
|
public CraftWorld getWorld() {
|
|
|
|
return this.world;
|
2015-06-16 12:55:15 +00:00
|
|
|
--
|
2016-02-29 23:09:49 +00:00
|
|
|
2.7.2
|
2015-06-16 12:55:15 +00:00
|
|
|
|