2020-04-30 14:59:24 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Mariell Hoversholm <proximyst@proximyst.com>
|
|
|
|
Date: Thu, 30 Apr 2020 16:56:54 +0200
|
|
|
|
Subject: [PATCH] Add Raw Byte ItemStack Serialization
|
|
|
|
|
|
|
|
Serializes using NBT which is safer for server data migrations than bukkits format.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/DataConverterRegistry.java b/src/main/java/net/minecraft/server/DataConverterRegistry.java
|
|
|
|
index 77c77973bb335cc89dae31bef2bbbcd4adc1d14b..d957d5fc2dc724cdda553e3a67ffe65e1e41c304 100644
|
|
|
|
--- a/src/main/java/net/minecraft/server/DataConverterRegistry.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/DataConverterRegistry.java
|
|
|
|
@@ -22,6 +22,7 @@ public class DataConverterRegistry {
|
|
|
|
return datafixerbuilder.build(SystemUtils.e());
|
|
|
|
}
|
|
|
|
|
|
|
|
+ public static DataFixer getDataFixer() { return a(); } // Paper - OBFHELPER
|
|
|
|
public static DataFixer a() {
|
|
|
|
return DataConverterRegistry.c;
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/ItemStack.java b/src/main/java/net/minecraft/server/ItemStack.java
|
|
|
|
index d6e43313bf0c678cf78fe77de2f8f4b6f819e3f4..ea60880c6f15b1a39579896d78cf641563621aa4 100644
|
|
|
|
--- a/src/main/java/net/minecraft/server/ItemStack.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/ItemStack.java
|
|
|
|
@@ -140,6 +140,7 @@ public final class ItemStack {
|
|
|
|
this.checkEmpty();
|
|
|
|
}
|
|
|
|
|
|
|
|
+ public static ItemStack fromCompound(NBTTagCompound nbttagcompound) { return a(nbttagcompound); } // Paper - OBFHELPER
|
|
|
|
public static ItemStack a(NBTTagCompound nbttagcompound) {
|
|
|
|
try {
|
|
|
|
return new ItemStack(nbttagcompound);
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/NBTCompressedStreamTools.java b/src/main/java/net/minecraft/server/NBTCompressedStreamTools.java
|
|
|
|
index 2322c0c8c5aacebb6317eab8ce4245554f6d9d55..3e6f878cdbbf5ebfa7fb390745ead135c1c4dee8 100644
|
|
|
|
--- a/src/main/java/net/minecraft/server/NBTCompressedStreamTools.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/NBTCompressedStreamTools.java
|
|
|
|
@@ -14,6 +14,7 @@ import java.util.zip.GZIPOutputStream;
|
|
|
|
|
|
|
|
public class NBTCompressedStreamTools {
|
|
|
|
|
|
|
|
+ public static NBTTagCompound readNBT(InputStream inputstream) throws IOException { return a(inputstream); } // Paper - OBFHELPER
|
|
|
|
public static NBTTagCompound a(InputStream inputstream) throws IOException {
|
|
|
|
DataInputStream datainputstream = new DataInputStream(new BufferedInputStream(new GZIPInputStream(inputstream)));
|
|
|
|
Throwable throwable = null;
|
|
|
|
@@ -43,6 +44,7 @@ public class NBTCompressedStreamTools {
|
|
|
|
return nbttagcompound;
|
|
|
|
}
|
|
|
|
|
|
|
|
+ public static void writeNBT(NBTTagCompound nbttagcompound, OutputStream outputstream) throws IOException { a(nbttagcompound, outputstream); } // Paper - OBFHELPER
|
|
|
|
public static void a(NBTTagCompound nbttagcompound, OutputStream outputstream) throws IOException {
|
|
|
|
DataOutputStream dataoutputstream = new DataOutputStream(new BufferedOutputStream(new GZIPOutputStream(outputstream)));
|
|
|
|
Throwable throwable = null;
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java b/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java
|
2020-05-22 05:08:18 +00:00
|
|
|
index 770375ed4207920e71d2d0799c611c4b3cdbe6f7..b58f2ef5ce5f3047bf8fcfc8d80a4aa9774ff711 100644
|
2020-04-30 14:59:24 +00:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java
|
|
|
|
@@ -313,6 +313,46 @@ public final class CraftMagicNumbers implements UnsafeValues {
|
|
|
|
public boolean isSupportedApiVersion(String apiVersion) {
|
|
|
|
return apiVersion != null && SUPPORTED_API.contains(apiVersion);
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public byte[] serializeItem(ItemStack item) {
|
|
|
|
+ Preconditions.checkNotNull(item, "null cannot be serialized");
|
|
|
|
+ Preconditions.checkArgument(item.getType() != Material.AIR, "air cannot be serialized");
|
|
|
|
+
|
|
|
|
+ java.io.ByteArrayOutputStream outputStream = new java.io.ByteArrayOutputStream();
|
|
|
|
+ NBTTagCompound compound = (item instanceof CraftItemStack ? ((CraftItemStack) item).getHandle() : CraftItemStack.asNMSCopy(item)).save(new NBTTagCompound());
|
|
|
|
+ compound.setInt("DataVersion", getDataVersion());
|
|
|
|
+ try {
|
|
|
|
+ net.minecraft.server.NBTCompressedStreamTools.writeNBT(
|
|
|
|
+ compound,
|
|
|
|
+ outputStream
|
|
|
|
+ );
|
|
|
|
+ } catch (IOException ex) {
|
|
|
|
+ throw new RuntimeException(ex);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ return outputStream.toByteArray();
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public ItemStack deserializeItem(byte[] data) {
|
|
|
|
+ Preconditions.checkNotNull(data, "null cannot be deserialized");
|
|
|
|
+ Preconditions.checkArgument(data.length > 0, "cannot deserialize nothing");
|
|
|
|
+
|
|
|
|
+ try {
|
|
|
|
+ NBTTagCompound compound = net.minecraft.server.NBTCompressedStreamTools.readNBT(
|
|
|
|
+ new java.io.ByteArrayInputStream(data)
|
|
|
|
+ );
|
|
|
|
+ int dataVersion = compound.getInt("DataVersion");
|
|
|
|
+
|
2020-05-18 17:24:06 +00:00
|
|
|
+ Preconditions.checkArgument(dataVersion <= getDataVersion(), "Newer version! Server downgrades are not supported!");
|
2020-05-22 05:08:18 +00:00
|
|
|
+ Dynamic<NBTBase> converted = DataConverterRegistry.getDataFixer().update(DataConverterTypes.ITEM_STACK, new Dynamic<NBTBase>(DynamicOpsNBT.a, compound), dataVersion, getDataVersion());
|
2020-04-30 14:59:24 +00:00
|
|
|
+ return CraftItemStack.asCraftMirror(net.minecraft.server.ItemStack.fromCompound((NBTTagCompound) converted.getValue()));
|
|
|
|
+ } catch (IOException ex) {
|
|
|
|
+ com.destroystokyo.paper.util.SneakyThrow.sneaky(ex);
|
|
|
|
+ throw new RuntimeException();
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
// Paper end
|
|
|
|
|
|
|
|
/**
|