2020-05-06 09:48:49 +00:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2016-03-18 05:35:26 +00:00
From: Aikar <aikar@aikar.co>
Date: Mon, 4 Mar 2013 23:46:10 -0500
Subject: [PATCH] Chunk Save Reattempt
We commonly have "Stream Closed" errors on chunk saving, so this code should re-try to save the chunk in the event of failure and hopefully prevent rollbacks.
diff --git a/src/main/java/net/minecraft/server/RegionFile.java b/src/main/java/net/minecraft/server/RegionFile.java
2020-06-25 11:00:35 +00:00
index d2977022d163edc5518dd4737c30cffd3eff5954..26b55108ecf4cd48762b00da625b0ce1d2f42c67 100644
2016-03-18 05:35:26 +00:00
--- a/src/main/java/net/minecraft/server/RegionFile.java
+++ b/src/main/java/net/minecraft/server/RegionFile.java
2020-06-25 11:00:35 +00:00
@@ -246,7 +246,7 @@ public class RegionFile implements AutoCloseable {
2019-12-11 02:43:21 +00:00
return true;
}
} catch (IOException ioexception) {
- com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(ioexception); // Paper
+ com.destroystokyo.paper.util.SneakyThrow.sneaky(ioexception); // Paper - we want the upper try/catch to retry this
return false;
}
2016-03-18 05:35:26 +00:00
}
2018-08-26 18:11:49 +00:00
diff --git a/src/main/java/net/minecraft/server/RegionFileCache.java b/src/main/java/net/minecraft/server/RegionFileCache.java
2020-06-25 11:00:35 +00:00
index 4d1de29e7c4bea266c544917fbe807a0b19462d6..4cff831de2128cd346f1f1627f0915d534b0d3bf 100644
2018-08-26 18:11:49 +00:00
--- a/src/main/java/net/minecraft/server/RegionFileCache.java
+++ b/src/main/java/net/minecraft/server/RegionFileCache.java
2020-06-25 11:00:35 +00:00
@@ -87,6 +87,7 @@ public final class RegionFileCache implements AutoCloseable {
2018-08-26 18:11:49 +00:00
2019-04-26 01:24:00 +00:00
protected void write(ChunkCoordIntPair chunkcoordintpair, NBTTagCompound nbttagcompound) throws IOException {
2019-12-11 02:43:21 +00:00
RegionFile regionfile = this.getFile(chunkcoordintpair, false); // CraftBukkit
2018-08-26 18:11:49 +00:00
+ int attempts = 0; Exception laste = null; while (attempts++ < 5) { try { // Paper
2019-04-26 01:24:00 +00:00
DataOutputStream dataoutputstream = regionfile.c(chunkcoordintpair);
Throwable throwable = null;
2019-12-11 02:43:21 +00:00
2020-06-25 11:00:35 +00:00
@@ -110,6 +111,18 @@ public final class RegionFileCache implements AutoCloseable {
2019-04-26 01:24:00 +00:00
}
2018-08-26 18:11:49 +00:00
2019-05-07 15:26:37 +00:00
+ // Paper start
+ return;
2019-04-26 01:24:00 +00:00
+ } catch (Exception ex) {
+ laste = ex;
+ }
2018-08-26 18:11:49 +00:00
+ }
2019-04-26 01:24:00 +00:00
+
2018-08-26 18:11:49 +00:00
+ if (laste != null) {
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(laste);
+ MinecraftServer.LOGGER.error("Failed to save chunk", laste);
+ }
2019-05-07 15:26:37 +00:00
+ // Paper end
2018-08-26 18:11:49 +00:00
}
2019-04-26 01:24:00 +00:00
public void close() throws IOException {