2020-05-06 09:48:49 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2016-03-09 04:42:08 +00:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Tue, 8 Mar 2016 23:25:45 -0500
|
|
|
|
Subject: [PATCH] Disable Scoreboards for non players by default
|
|
|
|
|
|
|
|
Entities collision is checking for scoreboards setting.
|
|
|
|
This is very heavy to do map lookups for every collision to check
|
|
|
|
this setting.
|
|
|
|
|
|
|
|
So avoid looking up scoreboards and short circuit to the "not on a team"
|
|
|
|
logic which is most likely to be true.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2020-05-06 09:48:49 +00:00
|
|
|
index abbf59bb91021821876a8960e8f77fac24457ec4..04430aae52205ee167662004e45c145b9d2e8bed 100644
|
2016-03-09 04:42:08 +00:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2020-01-18 17:28:32 +00:00
|
|
|
@@ -203,4 +203,9 @@ public class PaperWorldConfig {
|
2016-03-09 04:42:08 +00:00
|
|
|
private void disableTeleportationSuffocationCheck() {
|
|
|
|
disableTeleportationSuffocationCheck = getBoolean("disable-teleportation-suffocation-check", false);
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public boolean nonPlayerEntitiesOnScoreboards = false;
|
|
|
|
+ private void nonPlayerEntitiesOnScoreboards() {
|
|
|
|
+ nonPlayerEntitiesOnScoreboards = getBoolean("allow-non-player-entities-on-scoreboards", false);
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/Entity.java b/src/main/java/net/minecraft/server/Entity.java
|
2020-05-06 09:48:49 +00:00
|
|
|
index 5892d344ad9eb25af78aa45727beee216fd4e1ea..10855cec1e0bee6af0878bad0d0b05c5a637fad2 100644
|
2016-03-09 04:42:08 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/Entity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/Entity.java
|
2020-04-02 04:43:11 +00:00
|
|
|
@@ -2269,6 +2269,7 @@ public abstract class Entity implements INamableTileEntity, ICommandListener, Ke
|
2016-03-09 04:42:08 +00:00
|
|
|
|
2016-05-12 02:07:46 +00:00
|
|
|
@Nullable
|
2018-12-17 05:18:06 +00:00
|
|
|
public ScoreboardTeamBase getScoreboardTeam() {
|
2016-03-09 04:42:08 +00:00
|
|
|
+ if (!this.world.paperConfig.nonPlayerEntitiesOnScoreboards && !(this instanceof EntityHuman)) { return null; } // Paper
|
2018-07-15 01:53:17 +00:00
|
|
|
return this.world.getScoreboard().getPlayerTeam(this.getName());
|
2016-03-09 04:42:08 +00:00
|
|
|
}
|
|
|
|
|
2018-07-15 01:53:17 +00:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/EntityLiving.java b/src/main/java/net/minecraft/server/EntityLiving.java
|
2020-05-06 09:48:49 +00:00
|
|
|
index d4d60220efdf32ee84eef57a7155e7de513cf029..591bf14a6270a67e0bf705a90869c1223b9b36fd 100644
|
2018-07-15 01:53:17 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/EntityLiving.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/EntityLiving.java
|
2019-12-11 02:43:21 +00:00
|
|
|
@@ -535,6 +535,7 @@ public abstract class EntityLiving extends Entity {
|
2018-07-15 01:53:17 +00:00
|
|
|
if (nbttagcompound.hasKeyOfType("Team", 8)) {
|
|
|
|
String s = nbttagcompound.getString("Team");
|
|
|
|
ScoreboardTeam scoreboardteam = this.world.getScoreboard().getTeam(s);
|
|
|
|
+ if (!world.paperConfig.nonPlayerEntitiesOnScoreboards && !(this instanceof EntityHuman)) { scoreboardteam = null; } // Paper
|
2019-04-26 01:24:00 +00:00
|
|
|
boolean flag = scoreboardteam != null && this.world.getScoreboard().addPlayerToTeam(this.getUniqueIDString(), scoreboardteam);
|
2018-07-15 01:53:17 +00:00
|
|
|
|
|
|
|
if (!flag) {
|