2021-06-13 11:40:34 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
|
Date: Sat, 6 Apr 2019 10:16:48 -0400
|
|
|
|
|
Subject: [PATCH] Optimize Captured TileEntity Lookup
|
|
|
|
|
|
|
|
|
|
upstream was doing a containsKey/get pattern, and always doing it at that.
|
|
|
|
|
that scenario is only even valid if were in the middle of a block place.
|
|
|
|
|
|
|
|
|
|
Optimize to check if the captured list even has values in it, and also to
|
|
|
|
|
just do a get call since the value can never be null.
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/Level.java b/src/main/java/net/minecraft/world/level/Level.java
|
2021-06-21 08:09:18 +00:00
|
|
|
index 8076ad15b67d86b38ba61d701df921b0f615fd80..5b06aa23191d5e78cee7ac167ea39446c6c25b95 100644
|
2021-06-13 11:40:34 +00:00
|
|
|
--- a/src/main/java/net/minecraft/world/level/Level.java
|
|
|
|
|
+++ b/src/main/java/net/minecraft/world/level/Level.java
|
2021-06-21 08:09:18 +00:00
|
|
|
@@ -870,9 +870,12 @@ public abstract class Level implements LevelAccessor, AutoCloseable {
|
2021-06-13 11:40:34 +00:00
|
|
|
|
|
|
|
|
@Nullable
|
|
|
|
|
public BlockEntity getTileEntity(BlockPos blockposition, boolean validate) {
|
|
|
|
|
- if (this.capturedTileEntities.containsKey(blockposition)) {
|
|
|
|
|
- return this.capturedTileEntities.get(blockposition);
|
|
|
|
|
+ // Paper start - Optimize capturedTileEntities lookup
|
|
|
|
|
+ net.minecraft.world.level.block.entity.BlockEntity blockEntity;
|
|
|
|
|
+ if (!this.capturedTileEntities.isEmpty() && (blockEntity = this.capturedTileEntities.get(blockposition)) != null) {
|
|
|
|
|
+ return blockEntity;
|
|
|
|
|
}
|
|
|
|
|
+ // Paper end
|
|
|
|
|
// CraftBukkit end
|
|
|
|
|
return this.isOutsideBuildHeight(blockposition) ? null : (!this.isClientSide && Thread.currentThread() != this.thread ? null : this.getChunkAt(blockposition).getBlockEntity(blockposition, LevelChunk.EntityCreationType.IMMEDIATE));
|
|
|
|
|
}
|
