core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0346-Fix-sign-edit-memory-l...

48 lines
2.1 KiB
Diff
Raw Normal View History

Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 122289ff Add FaceAttachable interface to handle Grindstone facing in common with Switches a6db750e SPIGOT-5647: ZombieVillager entity should have getVillagerType() CraftBukkit Changes: bbe3d58e SPIGOT-5650: Lectern.setPage(int) causes a NullPointerException 3075579f Add FaceAttachable interface to handle Grindstone facing in common with Switches 95bd4238 SPIGOT-5647: ZombieVillager entity should have getVillagerType() 4d975ac3 SPIGOT-5617: setBlockData does not work when NotPlayEvent is called by redstone current
2020-04-02 21:07:06 +00:00
From e6fe80f05b58ef14d0b08b642a78738f02396df0 Mon Sep 17 00:00:00 2001
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
From: Aikar <aikar@aikar.co>
Date: Thu, 28 Feb 2019 00:15:28 -0500
Subject: [PATCH] Fix sign edit memory leak
when a player edits a sign, a reference to their Entity is never cleand up.
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 122289ff Add FaceAttachable interface to handle Grindstone facing in common with Switches a6db750e SPIGOT-5647: ZombieVillager entity should have getVillagerType() CraftBukkit Changes: bbe3d58e SPIGOT-5650: Lectern.setPage(int) causes a NullPointerException 3075579f Add FaceAttachable interface to handle Grindstone facing in common with Switches 95bd4238 SPIGOT-5647: ZombieVillager entity should have getVillagerType() 4d975ac3 SPIGOT-5617: setBlockData does not work when NotPlayEvent is called by redstone current
2020-04-02 21:07:06 +00:00
index 4b3ddfd990..2c94ca6a8e 100644
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
Update upstream B/CB --- work/Bukkit Submodule work/Bukkit 6a4242cb..337955e3: > SPIGOT-5468: Improve Beehive TileEntity API > #473: Add an API for passing the heightmap to getHighestBlockAt* method --- work/CraftBukkit Submodule work/CraftBukkit 807a677e..708be695: > SPIGOT-5468: Improve Beehive TileEntity API > #624: Add an API for passing the heightmap to getHighestBlockAt* method > MC-135989, SPIGOT-5564: Don't kick players for flight while riptiding This deprecates the Paper getHighestBlockAt HeightMap APIs now that Bukkit has added their own. These methods will stick around long enough for people to migrate. Their API is pretty much the same as ours, migration should be quick and easy.
2020-02-09 00:32:48 +00:00
@@ -2546,7 +2546,7 @@ public class PlayerConnection implements PacketListenerPlayIn {
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
TileEntitySign tileentitysign = (TileEntitySign) tileentity;
Update to 1.14.2
2019-05-27 23:01:45 +00:00
- if (!tileentitysign.d() || tileentitysign.f() != this.player) {
+ if (!tileentitysign.d() || tileentitysign.signEditor == null || !tileentitysign.signEditor.equals(this.player.getUniqueID())) {
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
this.minecraftServer.warning("Player " + this.player.getDisplayName().getString() + " just tried to change non-editable sign");
this.sendPacket(tileentity.getUpdatePacket()); // CraftBukkit
return;
diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 122289ff Add FaceAttachable interface to handle Grindstone facing in common with Switches a6db750e SPIGOT-5647: ZombieVillager entity should have getVillagerType() CraftBukkit Changes: bbe3d58e SPIGOT-5650: Lectern.setPage(int) causes a NullPointerException 3075579f Add FaceAttachable interface to handle Grindstone facing in common with Switches 95bd4238 SPIGOT-5647: ZombieVillager entity should have getVillagerType() 4d975ac3 SPIGOT-5617: setBlockData does not work when NotPlayEvent is called by redstone current
2020-04-02 21:07:06 +00:00
index 03f6ddf000..a934020190 100644
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
--- a/src/main/java/net/minecraft/server/TileEntitySign.java
+++ b/src/main/java/net/minecraft/server/TileEntitySign.java
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
@@ -10,6 +10,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
private EntityHuman c;
private final String[] g = new String[4];
private EnumColor color;
+ public java.util.UUID signEditor; // Paper
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
public TileEntitySign() {
Stop stripping private use block Unicode from signs Fixes GH-2943
2020-02-11 04:35:46 +00:00
super(TileEntityTypes.SIGN);
@@ -108,7 +109,10 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
}
public void a(EntityHuman entityhuman) {
Houston, we got a patch (#2731) * Houston, we got a patch * is this the end of the beginning or the beginning of the end
2019-12-12 16:20:43 +00:00
- this.c = entityhuman;
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
+ // Paper start
Houston, we got a patch (#2731) * Houston, we got a patch * is this the end of the beginning or the beginning of the end
2019-12-12 16:20:43 +00:00
+ //this.c = entityhuman;
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
+ signEditor = entityhuman != null ? entityhuman.getUniqueID() : null;
+ // Paper end
}
Update to 1.14.2
2019-05-27 23:01:45 +00:00
public EntityHuman f() {
Fix a sign memory leak
2019-02-28 05:47:57 +00:00
--
Drop Ignore-Missing-Recipes-in-RecipeBook-to-avoid-data-e.patch This patch appears to be no longer relevant, and is seemingly a leading cause of datapack performance being horrific
2020-03-15 20:03:36 +00:00
2.25.1
Fix a sign memory leak
2019-02-28 05:47:57 +00:00