core
/
testserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
testserver/Spigot-Server-Patches/0158-Remove-FishingHook-ref...

29 lines
967 B
Diff
Raw Normal View History

Current Chunk for Entity and Block Entities, counts by entity type This enables us a fast reference to the entities current chunk instead of having to look it up by hashmap lookups. We also store counts by type to further enable other performance optimizations in later patches.
2018-07-04 07:55:24 +00:00
From 1b510c55f2ced947504bbe7ecd6f5936f9a644f0 Mon Sep 17 00:00:00 2001
Remove FishingHook reference on Craft Entity removal This caused some bugs chickeneer reported to me, with fishing.
2016-09-22 03:45:05 +00:00
From: Aikar <aikar@aikar.co>
Date: Thu, 16 Jun 2016 00:17:23 -0400
Subject: [PATCH] Remove FishingHook reference on Craft Entity removal
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftFish.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftFish.java
Optimize Hoppers - Lots of itemstack cloning removed. Only clone if the item is actually moved - Return true when a plugin cancels inventory move item event instead of false, as false causes pulls to cycle through all items. However, pushes do not exhibit the same behavior, so this is not something plugins could of been relying on. - Add option (Default on) to cooldown hoppers when they fail to move an item due to full inventory - Skip subsequent InventoryMoveItemEvents if a plugin does not use the item after first event fire for an iteration
2018-01-18 06:00:51 +00:00
index d555597dc..f5419dea4 100644
Remove FishingHook reference on Craft Entity removal This caused some bugs chickeneer reported to me, with fishing.
2016-09-22 03:45:05 +00:00
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftFish.java
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftFish.java
Update patches that slipped through last
2018-01-05 07:30:03 +00:00
@@ -62,4 +62,14 @@ public class CraftFish extends AbstractProjectile implements Fish {
Validate.isTrue(chance >= 0 && chance <= 1, "The bite chance must be between 0 and 1.");
Remove FishingHook reference on Craft Entity removal This caused some bugs chickeneer reported to me, with fishing.
2016-09-22 03:45:05 +00:00
this.biteChance = chance;
}
Update patches that slipped through last
2018-01-05 07:30:03 +00:00
+
Remove FishingHook reference on Craft Entity removal This caused some bugs chickeneer reported to me, with fishing.
2016-09-22 03:45:05 +00:00
+ // Paper start
+ @Override
+ public void remove() {
+ super.remove();
+ if (getHandle().owner != null) {
+ getHandle().owner.hookedFish = null;
+ }
+ }
+ // Paper end
Update patches that slipped through last
2018-01-05 07:30:03 +00:00
}
Remove FishingHook reference on Craft Entity removal This caused some bugs chickeneer reported to me, with fishing.
2016-09-22 03:45:05 +00:00
--
Current Chunk for Entity and Block Entities, counts by entity type This enables us a fast reference to the entities current chunk instead of having to look it up by hashmap lookups. We also store counts by type to further enable other performance optimizations in later patches.
2018-07-04 07:55:24 +00:00
2.18.0
Remove FishingHook reference on Craft Entity removal This caused some bugs chickeneer reported to me, with fishing.
2016-09-22 03:45:05 +00:00