From c55c6f141bf65dc7ee69f6791c033950f7f0f29a Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 10:38:46 -0400 Subject: [PATCH 1/8] Update actions/checkout, set progress false --- .github/workflows/flutterfmt.yml | 4 +++- .github/workflows/gofmt.yml | 4 +++- .github/workflows/release.yml | 4 +++- .github/workflows/smoke.yml | 9 ++++++--- 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/flutterfmt.yml b/.github/workflows/flutterfmt.yml index af01091..ec3a049 100644 --- a/.github/workflows/flutterfmt.yml +++ b/.github/workflows/flutterfmt.yml @@ -21,7 +21,9 @@ jobs: flutter-version: '3.24.1' - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 + with: + progress: false - name: Check formating run: dart format -l120 lib/ --set-exit-if-changed --suppress-analytics --output none diff --git a/.github/workflows/gofmt.yml b/.github/workflows/gofmt.yml index 753ca5c..c43cd9a 100644 --- a/.github/workflows/gofmt.yml +++ b/.github/workflows/gofmt.yml @@ -22,7 +22,9 @@ jobs: id: go - name: Check out code into the Go module directory - uses: actions/checkout@v3 + uses: actions/checkout@v4 + with: + progress: false - name: Install goimports working-directory: nebula diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3d66aa4..769e232 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -27,7 +27,9 @@ jobs: flutter-version: '3.24.1' - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 + with: + progress: false - name: Install the appstore connect key material env: diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 3b62393..6b7e963 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -28,8 +28,9 @@ jobs: flutter-version: '3.24.1' - name: Check out code - uses: actions/checkout@v3 - + uses: actions/checkout@v4 + with: + progress: false - name: install dependencies env: TOKEN: ${{ secrets.MACHINE_USER_PAT }} @@ -96,7 +97,9 @@ jobs: flutter-version: '3.24.1' - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 + with: + progress: false - name: install dependencies run: | From 9cb90182087629f1ede90be94462c72b7ece2a0c Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 10:40:21 -0400 Subject: [PATCH 2/8] Update actions/setup-go --- .github/workflows/gofmt.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/smoke.yml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gofmt.yml b/.github/workflows/gofmt.yml index c43cd9a..7b6fd78 100644 --- a/.github/workflows/gofmt.yml +++ b/.github/workflows/gofmt.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Set up Go 1.22 - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version: "1.22" id: go diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 769e232..1b0f954 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Set up Go 1.22 - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version: "1.22" diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 6b7e963..8c8b0e7 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -13,7 +13,7 @@ jobs: runs-on: macos-latest steps: - name: Set up Go 1.22 - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version: "1.22" @@ -87,7 +87,7 @@ jobs: steps: - name: Set up Go 1.22 - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version: "1.22" From 836d2a45bfd819c2a840261e55f9dbd116a0ae9f Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 10:46:32 -0400 Subject: [PATCH 3/8] Fix go cache --- .github/workflows/release.yml | 11 ++++++----- .github/workflows/smoke.yml | 21 ++++++++++++--------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1b0f954..e5a114c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,10 +11,16 @@ jobs: runs-on: macos-latest steps: + - name: Check out code + uses: actions/checkout@v4 + with: + progress: false + - name: Set up Go 1.22 uses: actions/setup-go@v5 with: go-version: "1.22" + cache-dependency-path: nebula/go.sum - uses: actions/setup-java@v2 with: @@ -26,11 +32,6 @@ jobs: with: flutter-version: '3.24.1' - - name: Check out code - uses: actions/checkout@v4 - with: - progress: false - - name: Install the appstore connect key material env: AC_API_KEY_SECRET_BASE64: ${{ secrets.AC_API_KEY_SECRET_BASE64 }} diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 8c8b0e7..56e6e88 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -12,10 +12,16 @@ jobs: name: Android runs-on: macos-latest steps: + - name: Check out code + uses: actions/checkout@v4 + with: + progress: false + - name: Set up Go 1.22 uses: actions/setup-go@v5 with: go-version: "1.22" + cache-dependency-path: nebula/go.sum - uses: actions/setup-java@v2 with: @@ -27,10 +33,6 @@ jobs: with: flutter-version: '3.24.1' - - name: Check out code - uses: actions/checkout@v4 - with: - progress: false - name: install dependencies env: TOKEN: ${{ secrets.MACHINE_USER_PAT }} @@ -86,21 +88,22 @@ jobs: runs-on: macos-latest steps: + - name: Check out code + uses: actions/checkout@v4 + with: + progress: false + - name: Set up Go 1.22 uses: actions/setup-go@v5 with: go-version: "1.22" + cache-dependency-path: nebula/go.sum - name: Install flutter uses: subosito/flutter-action@v2 with: flutter-version: '3.24.1' - - name: Check out code - uses: actions/checkout@v4 - with: - progress: false - - name: install dependencies run: | go install golang.org/x/mobile/cmd/gomobile@latest From e391a9550c80bc3fa76b1533bff2ff91eb66807d Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 10:50:09 -0400 Subject: [PATCH 4/8] Update actions/setup-java --- .github/workflows/release.yml | 2 +- .github/workflows/smoke.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e5a114c..f18af8e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -22,7 +22,7 @@ jobs: go-version: "1.22" cache-dependency-path: nebula/go.sum - - uses: actions/setup-java@v2 + - uses: actions/setup-java@v4 with: distribution: 'zulu' java-version: '17' diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 56e6e88..8cee999 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -23,7 +23,7 @@ jobs: go-version: "1.22" cache-dependency-path: nebula/go.sum - - uses: actions/setup-java@v2 + - uses: actions/setup-java@v4 with: distribution: 'zulu' java-version: '17' From 24b46087daa1e8f4f6745d86f44ab5600fc2264b Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 12:35:51 -0400 Subject: [PATCH 5/8] Update upload-artifact --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f18af8e..100e4be 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -98,7 +98,7 @@ jobs: fi - name: Collect iOS artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: MobileNebula.ipa path: ios/MobileNebula.ipa @@ -122,7 +122,7 @@ jobs: fi - name: Collect Android artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: MobileNebula.aab path: build/app/outputs/bundle/release/app-release.aab From 6da94f1b4867f9fafbc60ae4a3f61ac8f318e673 Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 12:50:50 -0400 Subject: [PATCH 6/8] Replace deprecated github release action --- .github/workflows/release.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 100e4be..f4fdfcf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -141,16 +141,14 @@ jobs: cd android fastlane release - - name: Create Release + - name: Create GitHub Release id: create_release - uses: actions/create-release@v1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + uses: softprops/action-gh-release@v2 with: - tag_name: ${{ github.ref }} - release_name: Release ${{ github.ref }} + name: Release ${{ github.ref }} draft: true prerelease: false + token: ${{ secrets.GITHUB_TOKEN }} - name: Upload release Android app uses: actions/upload-release-asset@v1.0.1 From f0c0d4b49ea034620afc8c5e81458c1263cfa53d Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 12:59:29 -0400 Subject: [PATCH 7/8] Remove deprecated actions/upload-release-asset --- .github/workflows/release.yml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f4fdfcf..3c8916e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -141,6 +141,11 @@ jobs: cd android fastlane release + - name: Rename app bundle + run: | + mv build/app/outputs/bundle/release/app-release.aab \ + build/app/outputs/bundle/release/MobileNebula.aab + - name: Create GitHub Release id: create_release uses: softprops/action-gh-release@v2 @@ -149,16 +154,7 @@ jobs: draft: true prerelease: false token: ${{ secrets.GITHUB_TOKEN }} - - - name: Upload release Android app - uses: actions/upload-release-asset@v1.0.1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - upload_url: ${{ steps.create_release.outputs.upload_url }} - asset_path: build/app/outputs/bundle/release/app-release.aab - asset_name: MobileNebula.aab - asset_content_type: text/plain + files: build/app/outputs/bundle/release/MobileNebula.aab - name: Upload release iOS app uses: actions/upload-release-asset@v1.0.1 From 403fe7c41e36add850cc03c85ca5df17d22a7ae2 Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 22 Oct 2024 14:32:45 -0400 Subject: [PATCH 8/8] Update upload-artifact --- .github/workflows/smoke.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 8cee999..6aae882 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -77,9 +77,9 @@ jobs: unzip -p build/app/outputs/apk/debug/app-debug.apks universal.apk > build/app/outputs/apk/debug/app-debug.apk - name: Collect debug apk if: github.ref == 'refs/heads/main' - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: app-debug.apk + name: MobileNebulaDebug.apk path: build/app/outputs/apk/debug/app-debug.apk retention-days: 60