From 7874c9aa676297cb7f3ed5ca835dd59e085ed96c Mon Sep 17 00:00:00 2001 From: Shahram Najm Date: Thu, 17 Oct 2024 10:15:37 +0000 Subject: [PATCH 1/2] Testing: Check typeOfLevel=abstractLevel --- tests/grib_typeOfLevel.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/grib_typeOfLevel.sh b/tests/grib_typeOfLevel.sh index a036f3e72..4ac271552 100755 --- a/tests/grib_typeOfLevel.sh +++ b/tests/grib_typeOfLevel.sh @@ -59,5 +59,11 @@ ${tools_dir}/grib_set -s productDefinitionTemplateNumber=1 $tempGribA $tempGribB grib_check_key_equals $tempGribB typeOfLevel,productDefinitionTemplateNumber 'unknown 1' +# ECC-1847: Fix case when input has typeOfLevel=unknown +# In definitions/grib2/typeOfLevelConcept.def, make sure we map 'unknown' correctly (transient dummyc) +${tools_dir}/grib_set -s centre=ecmf,typeOfFirstFixedSurface=254 $sample_g2 $tempGribA +grib_check_key_equals $tempGribA typeOfLevel abstractLevel + + # Clean up rm -f $tempText $tempGribA $tempGribB From 8afc070fdafc0f8ea41d3669187a4acae029bd3b Mon Sep 17 00:00:00 2001 From: shahramn Date: Thu, 17 Oct 2024 13:56:09 +0100 Subject: [PATCH 2/2] ECC-1943: GRIB1: Add an entry for 10fg6 in stepTypeForConversion concept --- definitions/grib1/localConcepts/ecmf/stepTypeForConversion.def | 3 +++ 1 file changed, 3 insertions(+) diff --git a/definitions/grib1/localConcepts/ecmf/stepTypeForConversion.def b/definitions/grib1/localConcepts/ecmf/stepTypeForConversion.def index 25aae31d8..325bdf0c7 100644 --- a/definitions/grib1/localConcepts/ecmf/stepTypeForConversion.def +++ b/definitions/grib1/localConcepts/ecmf/stepTypeForConversion.def @@ -218,3 +218,6 @@ "avg"={gribTablesVersionNo=172;indicatorOfParameter=178;centre=98;} # mtntrf "avg"={gribTablesVersionNo=172;indicatorOfParameter=179;centre=98;} + +# 10fg6 +"max"={gribTablesVersionNo=128;indicatorOfParameter=123;centre=98;}