From db935ef8ffb1b071ce45e5364db2d0874654620f Mon Sep 17 00:00:00 2001
From: shahramn <shahram.najm@ecmwf.int>
Date: Mon, 14 Oct 2024 11:29:58 +0100
Subject: [PATCH] ECC-1936: Compilation error: identifier 'strcasestr' is
 undefined with nec compilers

---
 src/grib_expression_class_functor.cc | 35 +++++++++++-----------------
 tests/filter_contains.sh             |  4 ++--
 2 files changed, 16 insertions(+), 23 deletions(-)

diff --git a/src/grib_expression_class_functor.cc b/src/grib_expression_class_functor.cc
index eb147d963..45eb56460 100644
--- a/src/grib_expression_class_functor.cc
+++ b/src/grib_expression_class_functor.cc
@@ -9,7 +9,7 @@
  */
 
 #include "grib_api_internal.h"
-
+#include <string>
 /*
    This is used by make_class.pl
 
@@ -71,28 +71,21 @@ grib_expression_class* grib_expression_class_functor = &_grib_expression_class_f
 
 /* END_CLASS_IMP */
 
-
-#ifdef ECCODES_ON_WINDOWS
-// Windows does not have strcasestr
-static char* strcasestr(const char *haystack, const char* needle)
+static bool string_contains_case(const char* haystack, const char* needle, bool case_sensitive)
 {
-    char c, sc;
-    size_t len = 0;
+    std::string copy_haystack = haystack;
+    std::string copy_needle   = needle;
 
-    if ((c = *needle++) != 0) {
-        c = tolower((unsigned char)c);
-        len = strlen(needle);
-        do {
-            do {
-                if ((sc = *haystack++) == 0)
-                    return (NULL);
-            } while ((char)tolower((unsigned char)sc) != c);
-        } while (_strnicmp(haystack, needle, len) != 0);
-        haystack--;
+    if (!case_sensitive) {
+        // Convert both strings to lowercase if we don't care about case
+        std::transform(copy_needle.begin(), copy_needle.end(), copy_needle.begin(),
+                       [](unsigned char c) { return std::tolower(c); });
+        std::transform(copy_haystack.begin(), copy_haystack.end(), copy_haystack.begin(),
+                       [](unsigned char c) { return std::tolower(c); });
     }
-    return ((char *)haystack);
+    // Perform the search
+    return copy_haystack.find(copy_needle) != std::string::npos;
 }
-#endif
 
 static int evaluate_long(grib_expression* g, grib_handle* h, long* lres)
 {
@@ -214,8 +207,8 @@ static int evaluate_long(grib_expression* g, grib_handle* h, long* lres)
             err = grib_get_string(h, keyName, keyValue, &len);
             if (err) return err;
             const char* sValue = grib_arguments_get_string(h, e->args, 1);
-            const bool case_sens = grib_arguments_get_long(h, e->args, 2) != 0;
-            const bool contains = case_sens? strcasestr(keyValue, sValue) : strstr(keyValue, sValue);
+            const bool case_sens = grib_arguments_get_long(h, e->args, 2) == 0; // 0=case-sensitive, 1=case-insensitive
+            const bool contains = string_contains_case(keyValue, sValue, case_sens);
             if (sValue && contains) {
                 *lres = 1;
                 return GRIB_SUCCESS;
diff --git a/tests/filter_contains.sh b/tests/filter_contains.sh
index 681bc3906..684a9fc73 100755
--- a/tests/filter_contains.sh
+++ b/tests/filter_contains.sh
@@ -22,10 +22,10 @@ sample=$ECCODES_SAMPLES_PATH/GRIB2.tmpl
 cat > $tempFilt <<EOF
     if (! contains(identifier, "GR", 0) )  { assert (false); }
     if (! contains(identifier, "ib", 1) )  { assert (false); }
-    if (! contains(identifier, "", 1) )  { assert (false); }
+    if (! contains(identifier, "",   1) )  { assert (false); }
 
     if (contains(identifier, "grb", 1) ) { assert (false); }
-    if (contains(identifier, "ib", 0) ) { assert (false); }
+    if (contains(identifier, "ib",  0) ) { assert (false); }
 EOF
 cat $tempFilt
 ${tools_dir}/grib_filter $tempFilt $sample