core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update script to check grib concepts

This commit is contained in:
Shahram Najm 2015-06-26 18:10:29 +01:00
parent cae3419182
commit d9424f01e9
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
definitions/check_grib_defs.pl
View File

@ -176,11 +176,11 @@ sub process {
# So make sure it comes BEFORE the scale keys! i.e. if we find a scale key then our map should have # So make sure it comes BEFORE the scale keys! i.e. if we find a scale key then our map should have
# the typeOf key since it came before # the typeOf key since it came before
if ($key =~ /scale.*OfSecondFixedSurface/ && !exists($map2{'typeOfSecondFixedSurface'})) { if ($key =~ /scale.*OfSecondFixedSurface/ && !exists($map2{'typeOfSecondFixedSurface'})) {
print "File: $filename, line: $lineNum: 'Type of Surface' problem: Please check: $desc\n"; print "File: $filename, line: $lineNum: TypeOfSurface problem (GRIB-229): Please check: $desc\n";
#$error = 1; #$error = 1;
} }
if ($key =~ /typeOfSecondFixedSurface/ && exists($map2{'typeOfFirstFixedSurface'})) { if ($key =~ /typeOfSecondFixedSurface/ && exists($map2{'typeOfFirstFixedSurface'})) {
print "File: $filename, line: $lineNum: TypeOf1 before TypeOf2 problem: Please check: $desc\n"; print "File: $filename, line: $lineNum: Potential TypeOfSurface problem (GRIB-229): Please check: $desc\n";
} }
} }
$map2{$key} = $val; $map2{$key} = $val;
@ -188,7 +188,9 @@ sub process {
elsif ($this =~ /'(.*)'.*=/) { elsif ($this =~ /'(.*)'.*=/) {
$concept = $1; $concept = $1;
if ($filename eq 'cfVarName.def') { if ($filename eq 'cfVarName.def') {
if ($concept =~ /^[0-9]/) { #if ($concept =~ /^[0-9]/) {
# Check CF naming convention. Do not allow numeric initial char or ~
if ($concept !~ /^[A-z]/) {
$error = 1; $error = 1;
die "File: $filename, line: $lineNum: Invalid netcdf variable name: $concept"; die "File: $filename, line: $lineNum: Invalid netcdf variable name: $concept";
} }