From b9dcf3fb63485b3dac50d8f24078b2c0677a6bec Mon Sep 17 00:00:00 2001
From: shahramn <shahram.najm@ecmwf.int>
Date: Wed, 28 Feb 2024 16:03:46 +0000
Subject: [PATCH] ECC-1777: Validate dataDate and dataTime on input

---
 tests/grib_set_fail.sh | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/tests/grib_set_fail.sh b/tests/grib_set_fail.sh
index d4c2a0b4e..1a44b5a3b 100755
--- a/tests/grib_set_fail.sh
+++ b/tests/grib_set_fail.sh
@@ -95,17 +95,30 @@ status=$?
 set -e
 [ $status -ne 0 ]
 
-# Bad date
-# ---------
+# ECC-1777: Bad date/time
+# -------------------------
 input=$ECCODES_SAMPLES_PATH/GRIB2.tmpl
 ${tools_dir}/grib_set -s dataDate=20180229 $input $outfile > $temp 2>&1
-cat $temp
 grep -q "Date is not valid" $temp
 
 ${tools_dir}/grib_set -s dataTime=4261 $input $outfile > $temp 2>&1
-cat $temp
 grep -q "Time is not valid" $temp
 
+${tools_dir}/grib_set -s dataTime=2501 $input $outfile > $temp 2>&1
+grep -q "Time is not valid" $temp
+
+# Note for GRIB1 we DO fail on a bad date! This need to be consistent across editions
+input=$ECCODES_SAMPLES_PATH/GRIB1.tmpl
+set +e
+${tools_dir}/grib_set -s dataDate=20180229 $input $outfile > $temp 2>&1
+status=$?
+set -e
+[ $status -ne 0 ]
+grep -q "invalid date 20180229" $temp
+
+# 2016 did have 29th Feb
+${tools_dir}/grib_set -s dataDate=20160229 $input $outfile
+
 
 # ECC-1359: string that can be converted to an integer
 # ---------------------------------------------------