core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Testing: Invalid dump modes

This commit is contained in:
Shahram Najm 2023-08-13 14:27:43 +01:00
parent 0f220e44fe
commit 6b1af9c384
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/grib_dumper_class.cc
View File

@ -81,6 +81,16 @@ void grib_dump_content(const grib_handle* h, FILE* f, const char* mode, unsigned
{ {
grib_dumper* dumper; grib_dumper* dumper;
dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data); dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data);
if (!dumper) {
fprintf(stderr, "Here are some possible values for the dumper mode:\n");
for (size_t i = 0; i < NUMBER(table); i++) {
const char* t = table[i].type;
if (strstr(t, "bufr") == NULL && strstr(t, "grib") == NULL) {
fprintf(stderr, "\t%s\n", t);
}
}
return;
}
grib_dump_header(dumper, h); grib_dump_header(dumper, h);
grib_dump_accessors_block(dumper, h->root->block); grib_dump_accessors_block(dumper, h->root->block);
grib_dump_footer(dumper, h); grib_dump_footer(dumper, h);
@ -92,6 +102,7 @@ void grib_dump_keys(grib_handle* h, FILE* f, const char* mode, unsigned long fla
size_t i; size_t i;
grib_accessor* acc = NULL; grib_accessor* acc = NULL;
grib_dumper* dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data); grib_dumper* dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data);
if (!dumper) return;
for (i = 0; i < num_keys; ++i) { for (i = 0; i < num_keys; ++i) {
acc = grib_find_accessor(h, keys[i]); acc = grib_find_accessor(h, keys[i]);
if (acc) if (acc)
@ -125,6 +136,7 @@ void codes_dump_bufr_flat(grib_accessors_list* al, grib_handle* h, FILE* f, cons
grib_dumper* dumper = NULL; grib_dumper* dumper = NULL;
Assert(h->product_kind == PRODUCT_BUFR); Assert(h->product_kind == PRODUCT_BUFR);
dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data); dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data);
if (!dumper) return;
grib_dump_header(dumper, h); grib_dump_header(dumper, h);
grib_dump_accessors_list(dumper, al); grib_dump_accessors_list(dumper, al);
grib_dump_footer(dumper, h); grib_dump_footer(dumper, h);

5
tests/codes_dump_content.sh
View File

@ -11,7 +11,7 @@
. ./include.ctest.sh . ./include.ctest.sh
label="codes_dump_content_test" label="codes_dump_content_test"
temp=temp.$label.grib temp=temp.$label.txt
infile=$data_dir/sample.grib2 infile=$data_dir/sample.grib2
@ -20,5 +20,8 @@ for mode in $modes; do
$EXEC ${test_dir}/codes_dump_content $mode $infile $EXEC ${test_dir}/codes_dump_content $mode $infile
done done
${test_dir}/codes_dump_content rubbish $infile > $temp 2>&1
grep -q "ERROR.*Unknown type : 'rubbish' for dumper" $temp
# Clean up # Clean up
rm -f $temp rm -f $temp