Testing: Invalid dump modes

src/grib_dumper_class.cc

@@ -81,6 +81,16 @@ void grib_dump_content(const grib_handle* h, FILE* f, const char* mode, unsigned
 {
     grib_dumper* dumper;
     dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data);
+    if (!dumper) {
+        fprintf(stderr, "Here are some possible values for the dumper mode:\n");
+        for (size_t i = 0; i < NUMBER(table); i++) {
+            const char* t = table[i].type;
+            if (strstr(t, "bufr") == NULL && strstr(t, "grib") == NULL) {
+                fprintf(stderr, "\t%s\n", t);
+            }
+        }
+        return;
+    }
     grib_dump_header(dumper, h);
     grib_dump_accessors_block(dumper, h->root->block);
     grib_dump_footer(dumper, h);
@@ -92,6 +102,7 @@ void grib_dump_keys(grib_handle* h, FILE* f, const char* mode, unsigned long fla
     size_t i;
     grib_accessor* acc  = NULL;
     grib_dumper* dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data);
+    if (!dumper) return;
     for (i = 0; i < num_keys; ++i) {
         acc = grib_find_accessor(h, keys[i]);
         if (acc)
@@ -125,6 +136,7 @@ void codes_dump_bufr_flat(grib_accessors_list* al, grib_handle* h, FILE* f, cons
     grib_dumper* dumper = NULL;
     Assert(h->product_kind == PRODUCT_BUFR);
     dumper = grib_dumper_factory(mode ? mode : "serialize", h, f, flags, data);
+    if (!dumper) return;
     grib_dump_header(dumper, h);
     grib_dump_accessors_list(dumper, al);
     grib_dump_footer(dumper, h);

tests/codes_dump_content.sh

@@ -11,7 +11,7 @@
 . ./include.ctest.sh
 
 label="codes_dump_content_test"
-temp=temp.$label.grib
+temp=temp.$label.txt
 
 infile=$data_dir/sample.grib2
 
@@ -20,5 +20,8 @@ for mode in $modes; do
     $EXEC ${test_dir}/codes_dump_content $mode $infile
 done
 
+${test_dir}/codes_dump_content rubbish $infile > $temp 2>&1
+grep -q "ERROR.*Unknown type : 'rubbish' for dumper" $temp
+
 # Clean up
 rm -f $temp