From 5c9f0a04b872ec374ec6c606bb2c969b788d8780 Mon Sep 17 00:00:00 2001
From: Shahram Najm <masn@ecmwf.int>
Date: Mon, 21 Aug 2023 16:23:58 +0100
Subject: [PATCH] Testing: substring invalid cases

---
 tests/filter_substr.sh | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/tests/filter_substr.sh b/tests/filter_substr.sh
index bcf29ef44..37ffadbcc 100755
--- a/tests/filter_substr.sh
+++ b/tests/filter_substr.sh
@@ -34,5 +34,19 @@ EOF
 ${tools_dir}/grib_filter - $sample 2>$temp <<EOF
     transient xx = substr("abc", -1, -1);
 EOF
-grep -q "Invalid substring" $temp
+cat $temp
+grep -q "Invalid substring.*start=" $temp
+
+${tools_dir}/grib_filter - $sample 2>$temp <<EOF
+    transient xx = substr("abc", 0, 0);
+EOF
+cat $temp
+grep -q "Invalid substring.*length must be > 0" $temp
+
+${tools_dir}/grib_filter - $sample 2>$temp <<EOF
+    transient xx = substr("abc", 0, 8);
+EOF
+cat $temp
+grep -q "Invalid substring.*start.*length" $temp
+# Clean up
 rm -f $temp