core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clang static analyser: Dead assignment

This commit is contained in:
Shahram Najm 2020-02-12 18:02:38 +00:00
parent 40270d7bcf
commit 58e39c3197
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/grib_accessor_class_data_g2bifourier_packing.c
View File

@ -386,8 +386,9 @@ static double laplam(bif_trunc_t* bt, const double val[])
itab1 = (int*)malloc(sizeof(int) * kmax); itab1 = (int*)malloc(sizeof(int) * kmax);
itab2 = (int*)malloc(sizeof(int) * ((1 + bt->bif_i) * (1 + bt->bif_j))); itab2 = (int*)malloc(sizeof(int) * ((1 + bt->bif_i) * (1 + bt->bif_j)));
for (k = 0; k < kmax; k++) for (k = 0; k < kmax; k++) {
itab1[k] = 0; itab1[k] = 0;
}
/* /*
* Keep record of the possible values of i**2+j**2 outside the non-packed truncation * Keep record of the possible values of i**2+j**2 outside the non-packed truncation
@ -405,12 +406,13 @@ static double laplam(bif_trunc_t* bt, const double val[])
} }
l = 0; l = 0;
for (k = 0; k < kmax; k++) for (k = 0; k < kmax; k++) {
if (itab1[k]) { if (itab1[k]) {
itab2[l] = k; itab2[l] = k;
itab1[k] = l; itab1[k] = l;
l++; l++;
} }
}
lmax = l; lmax = l;
/* /*
@ -439,8 +441,13 @@ static double laplam(bif_trunc_t* bt, const double val[])
} }
else { else {
int m, ll = itab1[i * i + j * j]; int m, ll = itab1[i * i + j * j];
for (m = 0; m < 4; m++, isp++) for (m = 0; m < 4; m++, isp++) {
znorm[ll] = MAX(znorm[ll], fabs(val[isp])); DebugAssertAccess(znorm, (long)ll, (long)lmax);
DebugAssertAccess(val, (long)isp, bt->n_vals_bif);
if (ll < lmax && isp < bt->n_vals_bif) {
znorm[ll] = MAX(znorm[ll], fabs(val[isp]));
}
}
} }
} }