core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clang compiler warnings/type safety

This commit is contained in:
Shahram Najm 2018-06-05 14:33:27 +01:00
parent 5c576df574
commit 4f5a5f9a41
9 changed files with 14 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fortran/grib_fortran.c
View File

@ -1687,7 +1687,7 @@ int any_f_new_from_scanned_file(int* fid,int* msgid,int* gid)
/* fortran convention of 1 based index*/
const int n=*msgid-1;
l_message_info* msg=grib_oarray_get(info_messages,n);
l_message_info* msg=(l_message_info*)grib_oarray_get(info_messages,n);
if (msg && f) {
GRIB_MUTEX_INIT_ONCE(&once,&init);
@ -1759,7 +1759,7 @@ int any_f_new_from_loaded(int* msgid,int* gid)
/* fortran convention of 1 based index*/
const int n=*msgid-1;
l_binary_message* msg=grib_oarray_get(binary_messages,n);
l_binary_message* msg=(l_binary_message*)grib_oarray_get(binary_messages,n);
if (msg && msg->data)
h=grib_handle_new_from_message_copy (c,msg->data,msg->size);

4
src/grib_accessor_classes_hash.c
View File

@ -52,9 +52,7 @@ struct accessor_class_hash { char *name; grib_accessor_class **cclass;};
#endif
#endif
static unsigned int
grib_accessor_classes_get_id (str, len)
register const char *str;
register unsigned int len;
grib_accessor_classes_get_id (const char *str, unsigned int len)
{
static const unsigned short asso_values[] =
{

2
src/grib_dumper_class_bufr_encode_C.c
View File

@ -146,7 +146,7 @@ static int destroy(grib_dumper* d)
static char* lval_to_string(grib_context* c, long v)
{
char* sval=grib_context_malloc_clear(c,sizeof(char)*40);
char* sval=(char*)grib_context_malloc_clear(c,sizeof(char)*40);
if (v == GRIB_MISSING_LONG) sprintf(sval,"CODES_MISSING_LONG");
else sprintf(sval,"%ld",v);
return sval;

2
src/grib_dumper_class_bufr_encode_fortran.c
View File

@ -146,7 +146,7 @@ static int destroy(grib_dumper* d)
static char* lval_to_string(grib_context* c, long v)
{
char* sval=grib_context_malloc_clear(c,sizeof(char)*40);
char* sval=(char*)grib_context_malloc_clear(c,sizeof(char)*40);
if (v == GRIB_MISSING_LONG) sprintf(sval,"CODES_MISSING_LONG");
else sprintf(sval,"%ld",v);
return sval;

2
src/grib_dumper_class_bufr_encode_python.c
View File

@ -146,7 +146,7 @@ static int destroy(grib_dumper* d)
static char* lval_to_string(grib_context* c, long v)
{
char* sval=grib_context_malloc_clear(c,sizeof(char)*40);
char* sval=(char*)grib_context_malloc_clear(c,sizeof(char)*40);
if (v == GRIB_MISSING_LONG) sprintf(sval,"CODES_MISSING_LONG");
else sprintf(sval,"%ld",v);
return sval;

4
src/grib_hash_keys.c
View File

@ -51,9 +51,7 @@ struct grib_keys_hash { char* name; int id;};
#endif
#endif
static unsigned int
hash_keys (str, len)
register const char *str;
register unsigned int len;
hash_keys (const char *str, unsigned int len)
{
static const unsigned short asso_values[] =
{

6
src/grib_query.c
View File

@ -409,7 +409,7 @@ static grib_accessor* _grib_find_accessor(grib_handle* h, const char* name)
char* p = NULL;
DebugAssert(name);
p = strchr(name, '.');
p = strchr((char*)name, '.');
if ( p ) {
int i=0,len=0;
char name_space[MAX_NAMESPACE_LEN];
@ -439,7 +439,7 @@ char* grib_split_name_attribute(grib_context* c,const char* name,char* attribute
/*returns accessor name and attribute*/
size_t size=0;
char* accessor_name=NULL;
char* p = strstr(name, "->");
char* p = strstr((char*)name, "->");
if (!p) {
*attribute_name=0;
return (char*)name;
@ -502,7 +502,7 @@ grib_accessor* grib_find_accessor_fast(grib_handle* h, const char* name)
char* p = NULL;
DebugAssert(name);
p = strchr(name, '.');
p = strchr((char*)name, '.');
if ( p ) {
int i=0,len=0;
char name_space[MAX_NAMESPACE_LEN];

4
tools/bufr_compare.c
View File

@ -663,8 +663,8 @@ static int compare_values(grib_runtime_options* options, grib_handle* handle1, g
double packingError1=0,packingError2=0;
double value_tolerance=0;
grib_context* c=handle1->context;
char* first_str = (handles_swapped==0? "1st" : "2nd");
char* second_str = (handles_swapped==0? "2nd" : "1st");
const char* first_str = (handles_swapped==0? "1st" : "2nd");
const char* second_str = (handles_swapped==0? "2nd" : "1st");
type1=type;
type2=type;

4
tools/grib_compare.c
View File

@ -591,8 +591,8 @@ static int compare_values(grib_runtime_options* options,grib_handle* h1,grib_han
double packingError1=0,packingError2=0;
double value_tolerance=0;
grib_context* c=h1->context;
char* first_str = (handles_swapped==0? "1st" : "2nd");
char* second_str = (handles_swapped==0? "2nd" : "1st");
const char* first_str = (handles_swapped==0? "1st" : "2nd");
const char* second_str = (handles_swapped==0? "2nd" : "1st");
type1=type;
type2=type;