From 4766ba34cb026e5b8c76b9e556ab76e9725b3473 Mon Sep 17 00:00:00 2001
From: Shahram Najm <masn@ecmwf.int>
Date: Tue, 29 Sep 2020 16:14:31 +0100
Subject: [PATCH] ECC-1150: Added more tests

---
 tests/grib_ecc-1150.sh | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/tests/grib_ecc-1150.sh b/tests/grib_ecc-1150.sh
index fa2de3367..c0d8360e1 100755
--- a/tests/grib_ecc-1150.sh
+++ b/tests/grib_ecc-1150.sh
@@ -12,19 +12,21 @@
 set -u
 # ---------------------------------------------------------
 # This is the test for the JIRA issue ECC-1150
-# ECC-1150: keys 'lowerLimit' and 'upperLimit' cannot be MISSING
+# ECC-1150: keys 'lowerLimit' & 'upperLimit' cannot be MISSING
 # ---------------------------------------------------------
 label="grib_ecc-1150-test"
 tempGrib=temp.${label}.grib
 tempFilt=temp.${label}.filt
 
 in=$ECCODES_SAMPLES_PATH/GRIB2.tmpl
+
+# Lower limit
+# -------------
 ${tools_dir}/grib_set -s \
    productDefinitionTemplateNumber=5,scaleFactorOfLowerLimit=missing,scaledValueOfLowerLimit=missing \
    $in $tempGrib
 
-grib_check_key_equals $tempGrib lowerLimit MISSING
-grib_check_key_equals $tempGrib upperLimit 0
+grib_check_key_equals $tempGrib lowerLimit,upperLimit 'MISSING 0'
 
 cat > $tempFilt <<EOF
  print "lower=[lowerLimit], upper=[upperLimit]";
@@ -37,5 +39,24 @@ EOF
 ${tools_dir}/grib_filter $tempFilt $tempGrib
 
 
+# Try upper limit too
+# --------------------
+${tools_dir}/grib_set -s \
+   productDefinitionTemplateNumber=5,scaleFactorOfUpperLimit=missing,scaledValueOfUpperLimit=missing \
+   $in $tempGrib
+
+grib_check_key_equals $tempGrib lowerLimit,upperLimit '0 MISSING'
+
+cat > $tempFilt <<EOF
+ print "lower=[lowerLimit], upper=[upperLimit]";
+ transient llim_missing = missing(lowerLimit);
+ transient ulim_missing = missing(upperLimit);
+
+ assert( llim_missing == 0 );
+ assert( ulim_missing == 1 );
+EOF
+${tools_dir}/grib_filter $tempFilt $tempGrib
+
+
 # Clean up
 rm -f $tempGrib $tempFilt