core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Compiler warnings: set_but_not_used, code_is_unreachable

This commit is contained in:
shahramn 2024-03-23 19:19:08 +00:00
parent b17b0eaac6
commit 4030e49c85
2 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/gts_compare.cc
View File

@ -183,7 +183,7 @@ int grib_tool_init(grib_runtime_options* options)
onlyListed = 1;
if (grib_options_on("a") && !grib_options_on("c:")) {
printf("Error: -a option requires -c option. Please define a list of keys with the -c option.\n");
fprintf(stderr, "Error: -a option requires -c option. Please define a list of keys with the -c option.\n");
exit(1);
}
@ -571,7 +571,6 @@ static int compare_values(const grib_runtime_options* options, grib_handle* h1,
case GRIB_TYPE_BYTES:
// We do not want to compare the message itself
return 0;
break;
case GRIB_TYPE_LABEL:
break;
@ -580,9 +579,8 @@ static int compare_values(const grib_runtime_options* options, grib_handle* h1,
if (verbose) printf("\n");
printInfo(h1);
save_error(c, name);
printf("Cannot compare [%s], unsupported type %d\n", name, type1);
fprintf(stderr, "Cannot compare [%s], unsupported type %d\n", name, type1);
return GRIB_UNABLE_TO_COMPARE_ACCESSORS;
break;
}
return GRIB_SUCCESS;

13
tools/metar_compare.cc
View File

@ -16,8 +16,6 @@ grib_option grib_options[] = {
{ "d", 0, "Write different messages on files\n", 0, 1, 0 },
{ "T:", 0, 0, 1, 0, "M" }, /* METAR */
{ "c:", 0, 0, 0, 1, 0 },
{ "S:", "start", "First field to be processed.\n", 0, 1, 0 },
{ "E:", "end", "Last field to be processed.\n", 0, 1, 0 },
{ "a", 0, "-c option modifier. The keys listed with the option -c will be added to the list of keys compared without -c.\n", 0, 1, 0 },
{ "R:", 0, 0, 0, 1, 0 },
{ "A:", 0, 0, 0, 1, 0 },
@ -84,8 +82,6 @@ static int verbose = 0;
static double tolerance_factor = 1;
static int write_error = 0;
static grib_handle* global_handle = NULL;
static int start = -1;
static int end = -1;
static int write_count = 0;
GRIB_INLINE static double compare_double_absolute(const double* a, const double* b, const double* err)
@ -191,11 +187,6 @@ int grib_tool_init(grib_runtime_options* options)
grib_context* context = grib_context_get_default();
options->strict = 1;
if (grib_options_on("S:"))
start = atoi(grib_options_get_option("S:"));
if (grib_options_on("E:"))
end = atoi(grib_options_get_option("E:"));
if (grib_options_on("f"))
force = 1;
@ -734,7 +725,6 @@ static int compare_values(const grib_runtime_options* options, grib_handle* h1,
case GRIB_TYPE_BYTES:
return 0; // No such type for METAR
break;
case GRIB_TYPE_LABEL:
break;
@ -744,9 +734,8 @@ static int compare_values(const grib_runtime_options* options, grib_handle* h1,
printf("\n");
printInfo(h1);
save_error(c, name);
printf("Cannot compare [%s], unsupported type %d\n", name, type1);
fprintf(stderr, "Cannot compare [%s], unsupported type %d\n", name, type1);
return GRIB_UNABLE_TO_COMPARE_ACCESSORS;
break;
}
return GRIB_SUCCESS;