core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ECC-392: bufr_compare: should print double value as MISSING rather than -1e+100

This commit is contained in:
Shahram Najm 2016-11-28 18:04:06 +00:00
parent 65acbc9714
commit 2d6e816046
1 changed files with 36 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tools/bufr_compare.c
View File

@ -584,6 +584,13 @@ static void save_error(grib_context* c,const char* key)
}
}
static char* double_as_string(grib_context* c, double v)
{
char* sval=grib_context_malloc_clear(c, sizeof(char)*40);
if (v == GRIB_MISSING_DOUBLE) sprintf(sval,"MISSING");
else sprintf(sval,"%.20e",v);
return sval;
}
static int compare_values(grib_runtime_options* options, grib_handle* handle1, grib_handle *handle2, const char *name, int type)
{
size_t len1 = 0;
@ -906,6 +913,7 @@ static int compare_values(grib_runtime_options* options, grib_handle* handle1, g
save_error(c,name);
if (len1>1) {
printf("double [%s]: %d out of %ld different\n",name,countdiff,(long)len1);
if (dval1[imaxdiff] != GRIB_MISSING_DOUBLE && dval2[imaxdiff] != GRIB_MISSING_DOUBLE) {
if (compareAbsolute) printf(" max");
printf(" absolute diff. = %.16e,",fabs(dval1[imaxdiff]-dval2[imaxdiff]));
if (!compareAbsolute) printf(" max");
@ -913,6 +921,14 @@ static int compare_values(grib_runtime_options* options, grib_handle* handle1, g
printf("\n\tmax diff. element %d: %.20e %.20e",
imaxdiff,dval1[imaxdiff],dval2[imaxdiff]);
printf("\n\ttolerance=%.16e",value_tolerance);
} else {
/* One or both values are missing */
char* sval1 = double_as_string(c, dval1[imaxdiff]);
char* sval2 = double_as_string(c, dval2[imaxdiff]);
printf("\tdiff. element %d: %s %s", imaxdiff, sval1, sval2);
grib_context_free(c,sval1);
grib_context_free(c,sval2);
}
if (packingError2!=0 || packingError1!=0)
printf(" packingError: [%g] [%g]",packingError1,packingError2);
@ -927,11 +943,19 @@ static int compare_values(grib_runtime_options* options, grib_handle* handle1, g
}
printf("\n");
} else {
printf("double [%s]: [%.20e] != [%.20e]\n",
name,dval1[0],dval2[0]);
if (dval1[0] != GRIB_MISSING_DOUBLE && dval2[0] != GRIB_MISSING_DOUBLE) {
printf("double [%s]: [%.20e] != [%.20e]\n", name, dval1[0], dval2[0]);
printf("\tabsolute diff. = %g,",fabs(dval1[0]-dval2[0]));
printf(" relative diff. = %g\n",relative_error(dval1[0],dval2[0],value_tolerance));
printf("\ttolerance=%g\n",value_tolerance);
} else {
/* One or both values are missing */
char* sval1 = double_as_string(c, dval1[0]);
char* sval2 = double_as_string(c, dval2[0]);
printf("double [%s]: [%s] != [%s]\n", name, sval1, sval2);
grib_context_free(c,sval1);
grib_context_free(c,sval2);
}
}
}
}