core
/
eccodes
mirror of https://github.com/ecmwf/eccodes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Performance: unpack_string: reduce scope and buffer size

This commit is contained in:
Shahram Najm 2021-12-26 20:32:06 +00:00
parent 83f7aee39b
commit 0155057ea5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/grib_accessor_class_bufr_data_element.c
View File

@ -347,10 +347,9 @@ static int pack_string_array(grib_accessor* a, const char** v, size_t* len)
static int unpack_string(grib_accessor* a, char* val, size_t* len) static int unpack_string(grib_accessor* a, char* val, size_t* len)
{ {
grib_accessor_bufr_data_element* self = (grib_accessor_bufr_data_element*)a; grib_accessor_bufr_data_element* self = (grib_accessor_bufr_data_element*)a;
char* str = NULL; char* str = NULL;
char* p = 0; char* p = 0;
size_t slen = 0; size_t slen = 0;
char sval[100] = {0,};
double dval = 0; double dval = 0;
size_t dlen = 1; size_t dlen = 1;
@ -358,6 +357,7 @@ static int unpack_string(grib_accessor* a, char* val, size_t* len)
grib_context* c = a->context; grib_context* c = a->context;
if (self->type != BUFR_DESCRIPTOR_TYPE_STRING) { if (self->type != BUFR_DESCRIPTOR_TYPE_STRING) {
char sval[32] = {0,};
unpack_double(a, &dval, &dlen); unpack_double(a, &dval, &dlen);
sprintf(sval, "%g", dval); sprintf(sval, "%g", dval);
slen = strlen(sval); slen = strlen(sval);
@ -383,7 +383,7 @@ static int unpack_string(grib_accessor* a, char* val, size_t* len)
str = grib_context_strdup(c, self->stringValues->v[idx]->v[0]); str = grib_context_strdup(c, self->stringValues->v[idx]->v[0]);
} }
if (str == 0 || strlen(str) == 0) { if (str == NULL || strlen(str) == 0) {
grib_context_free(c, str); grib_context_free(c, str);
*len = 0; *len = 0;
*val = 0; *val = 0;